Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(repository): add listPullRequestReviews #454

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feature(repository): add listPullRequestReviews #454

wants to merge 1 commit into from

Conversation

SimonBarendse
Copy link

resolves #453

mtscout6
mtscout6 requested changes Jul 17, 2017
View reviewed changes
Copy link
Member

@mtscout6 mtscout6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add tests for this

@SimonBarendse SimonBarendse force-pushed the 453_list_pull_request_reviews branch 3 times, most recently from 16724f5 to c73059a Compare September 3, 2017 22:35
@SimonBarendse SimonBarendse changed the title Add listPullRequestReviews method to Repostitory class feature(repository): add listPullRequestReviews Sep 3, 2017
@SimonBarendse
Copy link
Author

@mtscout6 I've added a test.

@esbanarango
Copy link

@mtscout6 @SimonBarendse Anything in particular tat prevents this PR to be merged?

@j-rewerts
Copy link
Member

I think we've got to get this pointed to an actual test repository that has test reviews on it. @SimonBarendse Could you switch to using the test user for your test?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtscout6 mtscout6 mtscout6 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

List reviews on a Pull Request
4 participants
@SimonBarendse @esbanarango @j-rewerts @mtscout6