Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempted corrections for PHP8 #145

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

Miro-Collas
Copy link

@Miro-Collas Miro-Collas commented Aug 19, 2023

Attempted fix for #143

Caveats:

  • I make no guarantee that my fixes are the best possible; I am not a PHP programmer.
  • I have not tested all components in all their variations.
  • My fixes are for PHP8 and may not be compatible with earlier versions; again, I am not a PHP programmer.

If the author prefers to do things differently, I most certainly won't be offended if my PR is discarded. :-) My aim was to clear the many warnings we were getting, which I managed to do, and the changes I made work for us.

@Miro-Collas Miro-Collas mentioned this pull request Apr 25, 2024
Ref issue giterlizzi#146 (comment) 
Applied fix suggested by manuelebarraco
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant