New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add binary format for XML i/O #236
base: stable
Are you sure you want to change the base?
Conversation
// Create XML tree node | ||
gsXmlNode* new_node = internal::makeNode(name, mat, data); | ||
return new_node; | ||
std::ostringstream str; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
who uses that stream?
bn::encode_b64(arr,arr+n*mat.size(), std::back_inserter(enc)); | ||
break; | ||
default: | ||
GISMO_ERROR("Something went notably wrong.. "<< n); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Can only searialize matrices if sizeof(T) is 2, 4 or 8 bytes. Got "<<n<<" bytes."
return new_node; | ||
std::ostringstream str; | ||
// data.formatType() ? ascii, binary | ||
#if FALSE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
break; | ||
default: | ||
GISMO_ERROR("Something went notably wrong.. "<< n); | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove empty statement
namespace gismo { | ||
|
||
namespace internal { | ||
|
||
/* | ||
inline bool is_big_endian() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needed?
seems to be a good thing. made some comments |
NEW: base64 data encoding for XML I/O