Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: shared args between calls #106

Closed
wants to merge 1 commit into from
Closed

fix: shared args between calls #106

wants to merge 1 commit into from

Conversation

khamaileon
Copy link
Collaborator

@khamaileon khamaileon commented Jun 16, 2023 •
edited

@khamaileon khamaileon changed the title fix: shared args between calls issue #105 fix: shared args between calls Jun 16, 2023
nilsnolde
nilsnolde approved these changes Jun 19, 2023
View reviewed changes
Copy link
Member

@nilsnolde nilsnolde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, yeah, so not a bug in requests 😅 would'be been weird on second thought.. Thanks!

@nilsnolde
Copy link
Member

Hm, I suppose we should write a small test for this so we don't have any regression in the future. Let me know if you're up for that, otherwise I'll add one soon-ish.

@khamaileon
Copy link
Collaborator Author

Yesss, I had started to write one, but as I don't really know the project yet and it was taking up too much of my time, I gave up for the moment 😕

@khamaileon khamaileon force-pushed the master branch 2 times, most recently from 326e6f0 to 626daae Compare June 25, 2023 15:43
@khamaileon khamaileon closed this Jul 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nilsnolde nilsnolde nilsnolde approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@khamaileon @nilsnolde