Better document vue/vuetify installation #297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeezley
previously approved these changes
Jan 5, 2021
zachmullen
previously approved these changes
Jan 5, 2021
Merged
|
The issue is installing vue/vuetify for running tests and building demo app. Doing this is unsupported by yarn. After 4 years of debate, a maintainer has decided "you can do it with a plugin in yarn 2". There are weird packages to hack around it, but I don't feel good about using one. The proper yarn 1.X solution would be either a) a monorepo or b) an entirely separate repo for the demo app, neither of which is appropriate for the level of effort involved. I think my docs changes are still good. PTAL. |
subdavis
changed the title
|
@zachmullen this is the last thing blocking the 3.0 chain of events. Mostly just because I want the NPM page to include these changes. |
zachmullen
approved these changes
Jan 8, 2021
subdavis
pushed a commit
that referenced
this pull request
Jan 8, 2021
* peer dep * Revert peer dep * Wrong section
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Made both Vue and Vuetify peer dependencies.
Had to change the install guide to explicitly install vuetify, and realized I was just replicating Vuetify docs inline.
So I switched to recommending
vue add vuetifyas the install mechanism, since it does quite a lot of work that a user would otherwise have to guess from looking at the GWC package json and vue.config.jsThis way, for the most common case of "fresh project", you get a more first-class vuetify experience rather than trying to replicate our config by hand.