CEM electrodes: Example using Python and complex forward modeling #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
are still real!). * assembleCompleteElectrodeModel_ is more or less copied from its real-values counterpart, with a few required type changes * potentialsCEM_ is resized to hold the imaginary parts in calculateK_ * imaginary parts are then stored in potentialsCEM using the "new" inline function TmpToImagHACK * Warning: This commit still contains debug output
* cast 'start' and 'end' parameters to a numpy array to allow for array-based operations * Slightly rework the docstring
|
Thanks for the work. We need to check in detail if there are some side effects, hope this will not take to long. |
real-valued mode even if a complex modeling is requested
contact resistances for CEM electrodes:
* add the setter function setContactResistances so we can
directly set electrode contact resistances from the Python
side
* adding this function required slight changes in the internal
handling logic. Previously the code needed only to look for
contact impedances registered using the setter function, and thus it
was easier to decide which resistance type to actually use
(contact impedances and contact resistances can be converted to each
other if the electrode surface area is known). Now we solve this by an
explicit parameter `use_cimp` which decides if the provided impedance
(=true) or resistance (=false) vectors shall be used further.
* setter functions are overwritten by input from files
contactImpedance.map and contactResistance.map.
* resistance input always overwrites impedance input
…esistances parameters that can be used to set CEM contact impedances and contact resistances
if-statement and make output more consistent
contact impedances and resistances with the real-valued version of this function
and setting of multiple columns: data = pg.DataContainer() data[['a', 'b']] = [[1, 2, 3], [4, 5, 6]] print(data[['a', 'b']]) Also add a few tests for this new functionality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dear all,
I'm opening this draft pull request to make you aware of this ongoing work - its by far not finished yet and will probably still take some time before merging can be considered. Naturally, I appreciate any input/suggestions at any point..
This works aims to:
So far I mostly committed the complex modeling parts - I still need to polish a basic CEM example before committing.