Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add decimation plugin to chart #2557

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Dhoni77
Copy link
Contributor

@Dhoni77 Dhoni77 commented Oct 28, 2023

Closes #2553

  • Setup data decimation plugin to chart with default option

@dtslvr dtslvr self-requested a review October 28, 2023 18:50
Copy link
Member

@dtslvr dtslvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Dhoni77 😎 I have added very few comments.

Can you enable the option ([dataDecimation]="true") in

  • AdminMarketDataDetailComponent
  • HomeOverviewComponent
  • PositionDetailDialog

libs/ui/src/lib/line-chart/line-chart.component.ts Outdated Show resolved Hide resolved
libs/ui/src/lib/line-chart/line-chart.component.ts Outdated Show resolved Hide resolved
@Dhoni77
Copy link
Contributor Author

Dhoni77 commented Oct 29, 2023

cc @dtslvr

Copy link
Member

@dtslvr dtslvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the update, @Dhoni77. The code looks fine, unfortunately when I test it, I can't see any difference:

data-decimation

The first chart is configured with [dataDecimation]="false" and the second one with [dataDecimation]="true".

Ps: I have registered the plugin, but it also has no effect 🙁

@Dhoni77
Copy link
Contributor Author

Dhoni77 commented Oct 29, 2023

Thanks a lot for the update, @Dhoni77. The code looks fine, unfortunately when I test it, I can't see any difference:

data-decimation The first chart is configured with `[dataDecimation]="false"` and the second one with `[dataDecimation]="true"`.

Ps: I have registered the plugin, but it also has no effect 🙁

Will look into it @dtslvr

@dtslvr
Copy link
Member

dtslvr commented Nov 9, 2023

Will look into it @dtslvr

Were you able to find out anything, @Dhoni77?

@Dhoni77
Copy link
Contributor Author

Dhoni77 commented Nov 9, 2023

Will look into it @dtslvr

Were you able to find out anything, @Dhoni77?

Hi @dtslvr Unfortunately I couldn't find a solution to this

@dtslvr
Copy link
Member

dtslvr commented Nov 10, 2023

Hi @dtslvr Unfortunately I couldn't find a solution to this

No problem. Thanks for the update.

@karter16
Copy link

karter16 commented Feb 20, 2024

Just an FYI that the documentation on this states that the decimation will take effect when the threshold is exceeded. The threshold by default is set to 4x the width of the canvas. @dtslvr I don't believe that there are enough data points between 2016 and 2023 in your example to exceed the threshold.

Screenshot 2024-02-20 at 5 50 18 PM

For anyone picking this up in the future I'd suggest setting the threshold to a lower value.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup data decimation option in line chart component
3 participants