New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add decimation plugin to chart #2557
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Dhoni77 😎 I have added very few comments.
Can you enable the option ([dataDecimation]="true"
) in
AdminMarketDataDetailComponent
HomeOverviewComponent
PositionDetailDialog
cc @dtslvr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the update, @Dhoni77. The code looks fine, unfortunately when I test it, I can't see any difference:
The first chart is configured with [dataDecimation]="false"
and the second one with [dataDecimation]="true"
.
Ps: I have registered the plugin, but it also has no effect 🙁
Will look into it @dtslvr |
No problem. Thanks for the update. |
Just an FYI that the documentation on this states that the decimation will take effect when the threshold is exceeded. The threshold by default is set to 4x the width of the canvas. @dtslvr I don't believe that there are enough data points between 2016 and 2023 in your example to exceed the threshold. For anyone picking this up in the future I'd suggest setting the threshold to a lower value. |
Closes #2553