Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass Element itself to targetModal, not only 'id' of element #351

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pbek
Copy link

@pbek pbek commented Jul 7, 2020

Enables usage of library in web-components.
See #65 (comment)

image

@gstvribs
Copy link

You need to do this same thing this.modal = typeof targetModal === "string" ? document.getElementById(targetModal) : targetModal at the closeModal function

@code3z
Copy link

code3z commented Feb 10, 2022

please merge this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants