Merge the ghcjs --interactive branch into the ghc 8 branch #549
Conversation
at least it compiles
this change seems to fix it on ghc 7.10.2
There are still compilation errors, particularly in the DriverPipeline. I assume the ghc API changed from 7 to 8 and a few things have to be adapted for it to work again.
|
Thanks for doing the work so far. I'll have look soon. I'm not sure if the problems can be fixed easily, but if they can, I think it's reasonable to do this as a stop-gap solution, rather than switching over to external-interpreter immediately, as I had hoped. |
|
Is there any progress or hope? |
|
We reverted our projects to ghc7 because of this issue. |
|
Development without support for ghci/--interactive is imo a pain. So Iam also highly interessted for having it working. So I'd also like to ask if there is any progress in the last weeks/months for making it work on the ghc-8.0 branch? It become even more interessting/important as f.e. reflex started to use ghc-8 extensions like TypeApplications in its head branch (although there exists an pull request to remove them again: reflex-frp/reflex#116). But right now for me it is an issue of: Either use the current reflex or have ghci support, but not both). |
|
I dunno, if your companies and products depend on good ghcjs support, how about giving @luite a few thousand bucks for caring? Maybe through something like bountysource, but with actually viable amounts of money. |
|
Why is that bounty closed? Can I add money? |
|
I think they don’t support bounties on pull request. I’ve opened an issue, now it works: https://www.bountysource.com/issues/47081350-get-interactive-mode-to-work-in-the-ghc-8-branch |
|
@Profpatsch @alios Sorry for the slowness on reflex-frp/reflex#116! That's merged now. If there are other compatibility issues, please send PRs and I will do my best to merge them ASAP. By the way, have you guys tried using a GHC-based ghci workflow? With jsaddle-warp, it's quite nice. I'm sure there are limitations, but it works for us for all our normal work. |
|
I can attest that using jsaddle is absolutely amazing. The other plus is that you get GHC's fast compile/reload times. |
|
Has this PR stalled? |
I have started merging the ghcji changes into the new ghc 8 branch, but was only able to fix the few merge commits. The ghc API changed, so it still doesn’t compile.
@luite, can you take a look at it? Maybe there’s only a few trivial changes needed to make it work, and
--interactiveis a pretty major feature when developing Haskell.Update: We added a bountysource thingy, because apparently people want to throw money at the issue:
