Easier updating ghcjs-pkg for newer compilers #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh, and this included my previous PR, but if you merge/reject it I'll be happy to rebase this. |
Note that this patch - has not been validated with a test-run yet - has not been validated to compile on Windows - hides some of the possibly important unused/shadowning warnings.
Somebody with more understanding of the compiler should look at each of these warnings and decide how to fix the issue that they point at.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I got the original
ghc-pkgfrom the specified revision and stuck it in https://github.com/forked-upstream-packages-for-ghcjs/ghcjs/tree/vanilla-ghc-pkg, then did an-XOursmerge. That means to update to a new version, just dump the original as a new commit on that branch, and then merge again, and git will do a pretty good job fixing things automatically.I figured this might be useful with 8.0 around the corner. I also used it for a forthcoming change to
ghcjs-pkgI also wish to upstream.