Fix syntax for ghc js backend #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It would be nice to fix at least the two FFI imports just above ( |
hsyl20
reviewed
May 14, 2024
hamishmack
added a commit
that referenced
this pull request
May 22, 2024
PR #109 included #ifdef __GHCJS__ for the old GHCJS. ghcjs-dom-javascript is for the new GHC JS backend only (ghcjs-dom-jsffi is for the old GHCJS). This change also fixes js_objectToString
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Perhaps it is not the only location where syntax needs to be updated, but at least this change fixes js errors in my simple reflex application compiled with ghc-9.8's js backend.