Skip to content

Commit

Permalink
rc v1.5.0 (#313)
Browse files Browse the repository at this point in the history 
* Run revdep. 89 pass. 0 fail

* Bump version to 1.5.0

* run revdep again and update cran-comments. Check for submission

* spelling
  • Loading branch information
@schloerke
schloerke committed Mar 25, 2020
1 parent a5a20db commit e90c8aa
Show file tree
Hide file tree
Showing 13 changed files with 50 additions and 953 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
@@ -1,5 +1,5 @@
Package: GGally
Version: 1.4.1
Version: 1.5.0
License: GPL (>= 2.0)
Title: Extension to 'ggplot2'
Type: Package
Expand Down
2 changes: 1 addition & 1 deletion R/data-australia-pisa-2012.R
View file
@@ -1,4 +1,4 @@
#' Programme for International Student Assesment (PISA) 2012 Data for Australia
#' Programme for International Student Assessment (PISA) 2012 Data for Australia
#'
#' About PISA
#'
Expand Down
2 changes: 1 addition & 1 deletion R/ggnetworkmap.R
View file
Expand Up @@ -8,7 +8,7 @@ if(getRversion() >= "2.15.1") {

#' ggnetworkmap - Plot a network with ggplot2 suitable for overlay on a ggmap:: map ggplot, or other ggplot
#'
#' This is a descendent of the original \code{ggnet} function. \code{ggnet} added the innovation of plotting the network geographically.
#' This is a descendant of the original \code{ggnet} function. \code{ggnet} added the innovation of plotting the network geographically.
#' However, \code{ggnet} needed to be the first object in the ggplot chain. \code{ggnetworkmap} does not. If passed a \code{ggplot} object as its first argument,
#' such as output from \code{ggmap}, \code{ggnetworkmap} will plot on top of that chart, looking for vertex attributes \code{lon} and \code{lat} as coordinates.
#' Otherwise, \code{ggnetworkmap} will generate coordinates using the Fruchterman-Reingold algorithm.
Expand Down
95 changes: 36 additions & 59 deletions cran-comments.md
View file
@@ -1,88 +1,65 @@

## Comments

### 2017-5-17
### 2020-3-19

Altered test and added crosstalk as a suggests. Passes on travis, local mac, and against plotly (reason for test).
I've fixed the tests and the package now works with the latest (and prior) ggplot2 versions.

- Barret
Please let me know if there is anything else I can do.

Best,
Barret

### 2017-5-17

$GGally
'::' or ':::' import not declared from: ‘crosstalk’
'library' or 'require' call not declared from: ‘crosstalk’
### 2020-3-6

- Kurt
Dear maintainer,

### 2017-5-17
Please see the problems shown on
<https://cran.r-project.org/web/checks/check_results_GGally.html>.

Please let me know if there is anything else I can do!
Please correct before 2020-03-20 to safely retain your package on CRAN.

Thank you for your time.

- Barret
Best,
-k


#### Test environments and R CMD check results

* local OS X install
* R version 3.5.0 (2018-04-23)
Platform: system x86_64, darwin15.6.0
Running under: macOS High ierra 10.13.4
* 0 errors | 0 warnings | 0 notes

* travis-ci
* Known travis issue of setting a _JAVA_OPTIONS value. **These _JAVA_OPTIONS notes are false positives**

* R version 3.5.0 (2017-01-27)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 14.04.5 LTS
* 0 errors | 0 warnings | 1 note
* checking dependencies in R code ... NOTE
Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m

* R Under development (unstable) (2018-05-16 r74730)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 14.04.5 LTS
* 0 errors | 0 warnings | 1 note
* checking dependencies in R code ... NOTE
Picked up _JAVA_OPTIONS: -Xmx2048m -Xms512m
* local macOS install 10.15.3
* R 3.6.3
* travis-ci ubuntu
* oldrelease, R version 3.5.3 (2017-01-27)
* release, R version 3.6.2 (2017-01-27)
* devel, R Under development (unstable) (2020-03-13 r77948)

* rhub
* fedora-clang-devel
* http://builder.r-hub.io/status/GGally_1.3.3.tar.gz-9e96854baee648a5a65df453919ea45f
* 0 errors | 0 warnings | 1 note
* checking package dependencies ... NOTE
Package suggested but not available for checking: ‘scagnostics’
* Windows Server 2008 R2 SP1, R-devel, 32/64 bit
* Ubuntu Linux 16.04 LTS, R-release, GCC
* Fedora Linux, R-devel, clang, gfortran

* win-builder
* oldrelease
* release
* devel

* win-builder (devel and release)
* R version 3.5.0 (2018-04-23)
* 0 errors | 0 warnings | 0 notes
* R Under development (unstable) (2018-05-15 r74727)
* 0 errors | 0 warnings | 0 notes


## Reverse dependencies
#### R CMD check results

### Checked on
|field |value |
|:--------|:----------------------------|
|version |R version 3.5.0 (2018-04-23) |
|os |macOS High Sierra 10.13.4 |
|system |x86_64, darwin15.6.0 |
rhub - Fedora R-devel
* 0 errors | 0 warnings | 1 note
* checking package dependencies ... NOTE
Package suggested but not available for checking: ‘scagnostics’

No difference in test results from GGally upgrade: https://github.com/ggobi/ggally/blob/master/revdep/
Everything else
* 0 errors | 0 warnings | 0 notes

### Couldn't check (1)

|package |version |error |warning |note |
|:--------------------------|:-------|:-----|:-------|:----|
|[LANDD](problems.md#landd) |1.1.0 |1 | | |

## revdepcheck results

### Revdep Maintainers
We checked 89 reverse dependencies (72 from CRAN + 17 from BioConductor), comparing R CMD check results across CRAN and dev versions of this package.

Reverse dependency maintainers were not notified as no breaking changes occured.
* We saw 0 new problems
* We failed to check 0 packages
2 changes: 1 addition & 1 deletion man/australia_PISA2012.Rd
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/ggnetworkmap.Rd
View file

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions revdep/.gitignore
View file
Expand Up @@ -6,3 +6,5 @@ data.sqlite
*.html
*.rds
lib
*.nosync*
failures.md
78 changes: 5 additions & 73 deletions revdep/README.md
View file
Expand Up @@ -2,88 +2,20 @@

|field |value |
|:--------|:----------------------------|
|version |R version 3.5.0 (2018-04-23) |
|os |macOS High Sierra 10.13.4 |
|version |R version 3.6.3 (2020-02-29) |
|os |macOS Catalina 10.15.3 |
|system |x86_64, darwin15.6.0 |
|ui |X11 |
|language |(EN) |
|collate |en_US.UTF-8 |
|ctype |en_US.UTF-8 |
|tz |America/New_York |
|date |2018-05-17 |
|date |2020-03-19 |

# Dependencies

|package |old |new |Δ |
|:-------|:-----|:-----|:--|
|GGally |1.3.2 |1.3.3 |* |
|GGally |1.4.0 |1.5.0 |* |

# Revdeps

## Couldn't check (1)

|package |version |error |warning |note |
|:--------------------------|:-------|:-----|:-------|:----|
|[LANDD](problems.md#landd) |1.1.0 |1 | | |

## All (57)

|package |version |error |warning |note |
|:----------------------------------------------------------|:-------|:-----|:-------|:----|
|[auditor](problems.md#auditor) |0.2.1 | | |1 |
|BAS |1.5.0 | | | |
|[CINNA](problems.md#cinna) |1.1.41 | | |1 |
|clustrd |1.2.2 | | | |
|DescribeDisplay |0.2.5 | | | |
|[eechidna](problems.md#eechidna) |1.1 | | |1 |
|egoTERGM |1.0.0 | | | |
|fingerPro |1.0 | | | |
|fpp2 |2.3 | | | |
|freqparcoord |1.0.1 | | | |
|[ggbio](problems.md#ggbio) |1.28.0 |1 |1 |3 |
|ggmcmc |1.1 | | | |
|[ggraptR](problems.md#ggraptr) |1.0 | | |2 |
|gsynth |1.0.6 | | | |
|[httk](problems.md#httk) |1.8 | | |1 |
|[ICtest](problems.md#ictest) |0.3 | | |1 |
|imageData |0.1-41 | | | |
|[isomiRs](problems.md#isomirs) |1.8.0 |1 | | |
|[ITNr](problems.md#itnr) |0.2.0 | | |1 |
|[jmv](problems.md#jmv) |0.8.6.2 | | |1 |
|[LANDD](problems.md#landd) |1.1.0 |1 | | |
|[MAST](problems.md#mast) |1.6.1 | |1 |4 |
|mbgraphic |1.0.0 | | | |
|[MCbiclust](problems.md#mcbiclust) |1.4.0 |1 | | |
|[MissingDataGUI](problems.md#missingdatagui) |0.2-5 |1 | | |
|mlrMBO |1.1.1 | | | |
|[NormalizeMets](problems.md#normalizemets) |0.25 | | |3 |
|[nzelect](problems.md#nzelect) |0.4.0 | | |2 |
|OutliersO3 |0.5.4 | | | |
|[ParamHelpers](problems.md#paramhelpers) |1.10 |1 | | |
|[Pi](problems.md#pi) |1.8.0 |1 | | |
|[plotly](problems.md#plotly) |4.7.1 | | |1 |
|[pmxTools](problems.md#pmxtools) |0.1.0 | | |1 |
|[PopGenReport](problems.md#popgenreport) |3.0.0 | | |1 |
|PPforest |0.1.0 | | | |
|qualvar |0.2.0 | | | |
|QuantNorm |1.0.3 | | | |
|[randomForestExplainer](problems.md#randomforestexplainer) |0.9 | | |1 |
|[robCompositions](problems.md#robcompositions) |2.0.7 | | |2 |
|[robustbase](problems.md#robustbase) |0.93-0 | | |1 |
|[rrr](problems.md#rrr) |1.0.0 | | |1 |
|rwty |1.0.1 | | | |
|[scPipe](problems.md#scpipe) |1.2.0 |1 | | |
|[SeqSQC](problems.md#seqsqc) |1.2.0 | | |1 |
|SHELF |1.3.0 | | | |
|[specmine](problems.md#specmine) |2.0.3 | | |1 |
|spup |1.2-1 | | | |
|[staRdom](problems.md#stardom) |1.0.5 | | |1 |
|[survivALL](problems.md#survivall) |0.9.3 | | |1 |
|svdvis |0.1 | | | |
|texmex |2.4 | | | |
|[toaster](problems.md#toaster) |0.5.5 | | |1 |
|[TVTB](problems.md#tvtb) |1.6.0 |1 |1 |2 |
|userfriendlyscience |0.7.1 | | | |
|[vdmR](problems.md#vdmr) |0.2.5 | | |1 |
|[vidger](problems.md#vidger) |1.0.0 | | |1 |
|vortexR |1.1.5 | | | |

37 changes: 0 additions & 37 deletions revdep/email.md
View file

This file was deleted.

4 changes: 0 additions & 4 deletions revdep/email.yml
View file

This file was deleted.

0 comments on commit e90c8aa

Please sign in to comment.