Give exitcode to systemd service

[kroese]

Always when booting my system I get this error in my log:

systemd[1]: umbrel-startup.service: Failed with result 'exit-code'.

I have verified that the start script runs succesfully until the end, and the system is working fine.

So my only guess is that systemd requires you to set the succesful exitcode explicitly, and this patch takes care of that.

[nmfretz]

Hey @kroese, taking a look at this now. I can't seem to recreate this issue that you encounter. I see the following output after a successful boot:
systemd[1]: Started Umbrel Startup Service.

What are you running Umbrel on?

[kroese]

I'm using Ubuntu 23.04 since recently, but before on Ubuntu 22.10 I had the same issue.

When you don't set an exitcode explicitly at the end of a script, it will use the code from the last executed command, and if that happens to be non-zero the script will also return non-zero. That behaviour is not always wanted.

But to be honest I did not test this patch to see if it fixed the issue, I just theorized what could be happening and wanted to prevent it.

In my log it just says: Failed to start Umbrel Startup Service so it's kind of hard to debug because it does not provide any reason.

Is there any way how I could debug this? I need to get systemd to print the actual exitcode to the log to see where it fails.