Do not read garbage CacheError markers
#1395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loewenheim
approved these changes
Feb 29, 2024
anonrig
reviewed
Feb 29, 2024
| /// This reads the string only up to the first NUL-byte. | ||
| /// We have observed broken cache files which were not properly truncated. | ||
| /// They had a valid `CacheError` prefix, followed by gigabytes worth of NUL-bytes, and some junk at the end. | ||
| fn utf8_message(raw_message: &[u8]) -> Cow<'_, str> { |
There was a problem hiding this comment.
I think we should add some tests for this particular function. Wdyt @getsentry/processing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1386. We have observed that cache cleanup fails because of a corrupted file.
That file contained a valid
CacheErrorprefix, but then gigabytes worth of NUL-bytes, plus some garbage.This change works around this corrupted file by only reading the valid
CacheErrorprefix, and not more.