Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Ubuntu symbol server test #1128

Merged
merged 1 commit into from
Apr 6, 2023
Merged

Skip Ubuntu symbol server test #1128

merged 1 commit into from
Apr 6, 2023

Conversation

Swatinem
Copy link
Member

@Swatinem Swatinem commented Apr 6, 2023

According to the FAQ at https://ubuntu.com/server/docs/service-debuginfod-faq:

Once a release goes unsupported, we [...] eventually stop serving debug symbols for its packages.

So I guess with those "stability" guarantees we either have to constantly update the testcase with up-to-date debug-ids, or we just skip it entirely :-(

#skip-changelog

According to the FAQ at https://ubuntu.com/server/docs/service-debuginfod-faq:

> Once a release goes unsupported, we [...] eventually stop serving debug symbols for its packages.

So I guess with those "stability" guarantees we either have to constantly update the testcase with up-to-date debug-ids, or we just skip it entirely :-(
@Swatinem Swatinem requested a review from a team April 6, 2023 12:39
@codecov
Copy link

codecov bot commented Apr 6, 2023

Codecov Report

Merging #1128 (63bd614) into master (4ad4a4b) will increase coverage by 0.05%.
The diff coverage is 80.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1128      +/-   ##
==========================================
+ Coverage   73.89%   73.94%   +0.05%     
==========================================
  Files          86       86              
  Lines       12748    12783      +35     
==========================================
+ Hits         9420     9453      +33     
- Misses       3328     3330       +2     

Copy link
Contributor

@kamilogorek kamilogorek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😢

@kamilogorek kamilogorek enabled auto-merge (squash) April 6, 2023 13:47
@kamilogorek kamilogorek merged commit ef0c44c into master Apr 6, 2023
13 checks passed
@kamilogorek kamilogorek deleted the skip-ubuntu branch April 6, 2023 14:51
@ashwoods
Copy link
Contributor

ashwoods commented Apr 6, 2023

For consistency, I think we should self-host whatever we want to test against.

@Swatinem
Copy link
Member Author

Swatinem commented Apr 6, 2023

I agree, as this evidently is a point of failure. However these tests explicitly hit these very specific external symbol servers. We also have #1004 as we hit the microsoft symbol server more than we absolutely need to. In that case we should also keep at least one test around that actually does hit it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants