Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup parses all the cache errors #1386

Open
Swatinem opened this issue Feb 27, 2024 · 1 comment
Open

Cleanup parses all the cache errors #1386

Swatinem opened this issue Feb 27, 2024 · 1 comment

Comments

@Swatinem
Copy link
Member

Because we have different retry / expiration policies for different cache errors, we are eagerly parsing the CacheError in check_expiry.

Though this code path is used both in main symbolicator, as well as in the cleanup job. Parsing the CacheError variants from the file involves String::from_utf8_lossy, which allocates and can thus OOM the cleanup task.

It is a bit weird though that the cleanup task is using as much memory and OOM-ing, as ideally none of these errors should not be that large ideally.

@jernejstrasner
Copy link

About half of this is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants