Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop needlessly using the public microsoft symbol server in tests #1004

Open
loewenheim opened this issue Feb 1, 2023 · 1 comment
Open

Stop needlessly using the public microsoft symbol server in tests #1004

loewenheim opened this issue Feb 1, 2023 · 1 comment
Labels
backlog Will be investigated and fixed at a later point

Comments

@loewenheim
Copy link
Contributor

The microsoft symbol server is used incidentally in some tests, like

symbolicator/crates/symbolicator/src/endpoints/minidump.rs

Line 114 in 9fa7f39

let source = test::microsoft_symsrv();
. We should replace these uses with local fixtures to reduce test duration.
@loewenheim loewenheim added the backlog Will be investigated and fixed at a later point label Feb 1, 2023
@loewenheim loewenheim mentioned this issue Feb 1, 2023
Merged
@vaind
Copy link
Contributor

vaind commented Mar 31, 2023

There are now also tests that fetch source links from HTTP, e.g. test_dotnet_source_links_in_app. I think these could be mocked as well.

@Swatinem Swatinem mentioned this issue Apr 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backlog Will be investigated and fixed at a later point
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vaind @loewenheim