Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rust): Minor logging improvements #5838

Merged
merged 1 commit into from May 1, 2024

Conversation

nikhars
Copy link
Member

@nikhars nikhars commented Apr 30, 2024

Remove a confusing log entry.

@nikhars nikhars requested review from a team as code owners April 30, 2024 19:12
@nikhars nikhars enabled auto-merge (squash) April 30, 2024 21:23
@nikhars nikhars merged commit 42fa3c0 into master May 1, 2024
30 checks passed
@nikhars nikhars deleted the nikhars/chore/remove-rust-logging branch May 1, 2024 18:44
@williamdes
Copy link

I guess my logs will be happier empty, but debug level would make sense
The actual code after merge is still confusing, it shows a success without documenting a partial fail

Ref: getsentry/self-hosted#2876 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants