Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't log secrets #5693

Merged
merged 1 commit into from Mar 27, 2024
Merged

fix: don't log secrets #5693

merged 1 commit into from Mar 27, 2024

Conversation

lynnagara
Copy link
Member

fix #5664

@lynnagara lynnagara requested review from a team as code owners March 27, 2024 00:01
Copy link

codecov bot commented Mar 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.85%. Comparing base (bbaa4a0) to head (07399ae).
Report is 16 commits behind head on master.

✅ All tests successful. No failed tests found ☺️

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5693      +/-   ##
==========================================
- Coverage   89.91%   89.85%   -0.07%     
==========================================
  Files         895      900       +5     
  Lines       43404    43747     +343     
  Branches      299      301       +2     
==========================================
+ Hits        39028    39310     +282     
- Misses       4334     4395      +61     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lynnagara lynnagara merged commit 6281a9a into master Mar 27, 2024
32 checks passed
@lynnagara lynnagara deleted the dont-log-secrets branch March 27, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rust consumer dumps config with secrets on INFO level
2 participants