fix(autofix): Properly check for existing installation and code mappings #71162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
malwilley
commented
May 20, 2024
| @@ -119,10 +114,6 @@ def get(self, request: Request, group: Group) -> Response: | |||
|
|
|||
| return Response( | |||
| { | |||
| "subprocessorConsent": { | |||
There was a problem hiding this comment.
I also went ahead and removed this part since we don't actually need it anymore, the genAIConsent flag will be off in this instance and the settings page will alert you that configuration is necessary
jennmueng
approved these changes
May 20, 2024
| return "integration_missing" | ||
|
|
||
| if integration.status != ObjectStatus.ACTIVE: | ||
| return "integration_inactive" | ||
| code_mappings = get_sorted_code_mapping_configs(project) |
There was a problem hiding this comment.
Oh didn't know this util existed, should be using it for how the other autofix endpoints gets the code mappings too. I'll make a quick refactor
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #71162 +/- ##
===========================================
+ Coverage 56.76% 77.88% +21.11%
===========================================
Files 6519 6528 +9
Lines 290530 290824 +294
Branches 50279 50329 +50
===========================================
+ Hits 164933 226515 +61582
+ Misses 120851 58067 -62784
- Partials 4746 6242 +1496
|
cmanallen
pushed a commit
that referenced
this pull request
May 21, 2024
…ngs (#71162) While running through this, I found an issue with how the setup check is looking at the integration, so made a couple changes: 1. Pass `project` in to the integration check so we can find code mappings for that project and error if not there 2. Checks for the integration's installation instead of the organization integration, which I think is more correct 3. Stop checking for whether it is disabled since Autofix only really needs the code mappings
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While running through this, I found an issue with how the setup check is looking at the integration, so made a couple changes:
projectin to the integration check so we can find code mappings for that project and error if not there