perf: replace json parser with orjson #71155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anonrig
requested review from
Lms24 and
andreiborza
and removed request for
a team
github-actions
bot
added
the
Scope: Backend
asottile-sentry
approved these changes
May 20, 2024
| @@ -416,7 +416,7 @@ def _find_source_file_in_artifact_indexes(self): | |||
| self._get_dist_matched_artifact_index_release_file() | |||
| ) | |||
| if dist_matched_artifact_index_release_file is not None: | |||
| raw_data = json.load(dist_matched_artifact_index_release_file.file.getfile()) | |||
| raw_data = orjson.loads(dist_matched_artifact_index_release_file.file.getfile().read()) | |||
There was a problem hiding this comment.
oh interesting, this might be the leaked socket I've been looking for
each call to getfile should be wrapped in context manager otherwise it leaks a file descriptor
no need to fix here though
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #71155 +/- ##
==========================================
- Coverage 77.86% 77.74% -0.13%
==========================================
Files 6528 6528
Lines 290845 290849 +4
Branches 50338 50338
==========================================
- Hits 226467 226108 -359
- Misses 58128 58523 +395
+ Partials 6250 6218 -32
|
anonrig
force-pushed
the
anonrig/more-orjson-why-not
branch
from
42515a0
to
eb7177e
Compare
|
@asottile-sentry Can you re-review? I had to make some changes due to failing tests. |
anonrig
force-pushed
the
anonrig/more-orjson-why-not
branch
from
eb7177e
to
b6e4e87
Compare
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
anonrig
added a commit
that referenced
this pull request
May 20, 2024
It seems we have a missing test coverage for this. Ref #71155 (comment) Fixes https://sentry-st.sentry.io/issues/5380029738/?project=1513938
|
PR reverted: c7ebc22 |
getsentry-bot
added a commit
that referenced
this pull request
May 20, 2024
This reverts commit 63cb2b2. Co-authored-by: wedamija <6288560+wedamija@users.noreply.github.com>
cmanallen
pushed a commit
that referenced
this pull request
May 21, 2024
Part of `orjson` move to get rid of `sentry.utils.json`
cmanallen
pushed a commit
that referenced
this pull request
May 21, 2024
It seems we have a missing test coverage for this. Ref #71155 (comment) Fixes https://sentry-st.sentry.io/issues/5380029738/?project=1513938
cmanallen
pushed a commit
that referenced
this pull request
May 21, 2024
This reverts commit 63cb2b2. Co-authored-by: wedamija <6288560+wedamija@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of
orjsonmove to get rid ofsentry.utils.json