Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: move interfaces and integrations to orjson #71055

Merged
merged 1 commit into from
May 20, 2024
Merged

perf: move interfaces and integrations to orjson #71055

merged 1 commit into from
May 20, 2024

Conversation

anonrig
Copy link
Member

@anonrig anonrig commented May 16, 2024

Part of orjson move to get rid of sentry.utils.json

@anonrig anonrig requested review from a team as code owners May 16, 2024 20:44
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label May 16, 2024
iambriccardo
iambriccardo approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

asottile-sentry
asottile-sentry approved these changes May 16, 2024
View reviewed changes
Copy link
Member

@asottile-sentry asottile-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/sentry/interfaces/http.py Outdated Show resolved Hide resolved
src/sentry/testutils/cases.py Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems May 16, 2024
View reviewed changes
src/sentry/utils/samples.py Dismissed Show dismissed Hide dismissed
@anonrig anonrig force-pushed the anonrig/more-and-more-orjson branch from de3c2df to 431d6bf Compare May 16, 2024 20:58
@anonrig anonrig enabled auto-merge (squash) May 16, 2024 21:01
@anonrig anonrig force-pushed the anonrig/more-and-more-orjson branch from 431d6bf to f9ff5a2 Compare May 16, 2024 21:06
@codecov Codecov
Copy link

codecov bot commented May 16, 2024 •
edited

Codecov Report

Attention: Patch coverage is 82.92683% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 77.88%. Comparing base (dfc0962) to head (3e7377d).

❗ Current head 3e7377d differs from pull request most recent head 6bf3625

Please upload reports for the commit 6bf3625 to get more accurate results.

Additional details and impacted files 
@@             Coverage Diff             @@
##           master   #71055       +/-   ##
===========================================
+ Coverage   41.97%   77.88%   +35.90%     
===========================================
  Files        6519     6528        +9     
  Lines      290525   290851      +326     
  Branches    50278    50339       +61     
===========================================
+ Hits       121959   226519   +104560     
+ Misses     161830    58085   -103745     
+ Partials     6736     6247      -489
Files Coverage Δ
src/sentry/interfaces/security.py 89.36% <100.00%> (+19.14%) ⬆️
src/sentry/shared_integrations/client/base.py 87.45% <100.00%> (+44.93%) ⬆️
.../sentry/shared_integrations/exceptions/__init__.py 91.89% <100.00%> (+27.92%) ⬆️
src/sentry/shared_integrations/response/base.py 71.18% <100.00%> (+28.81%) ⬆️
src/sentry/testutils/helpers/backups.py 99.41% <100.00%> (+2.63%) ⬆️
...y/testutils/performance_issues/event_generators.py 94.59% <100.00%> (+24.32%) ⬆️
src/sentry/utils/assets.py 100.00% <100.00%> (+20.83%) ⬆️
src/sentry/utils/codecs.py 100.00% <100.00%> (+28.88%) ⬆️
src/sentry/utils/email/message_builder.py 91.89% <100.00%> (+48.35%) ⬆️
src/sentry/utils/outcomes.py 98.11% <100.00%> (+9.65%) ⬆️
... and 8 more

... and 4333 files with indirect coverage changes

@anonrig anonrig force-pushed the anonrig/more-and-more-orjson branch from f9ff5a2 to a900b06 Compare May 20, 2024 13:12
@anonrig anonrig requested a review from a team as a code owner May 20, 2024 13:12
@anonrig anonrig force-pushed the anonrig/more-and-more-orjson branch from a900b06 to 7173270 Compare May 20, 2024 14:48
@anonrig anonrig force-pushed the anonrig/more-and-more-orjson branch from 7173270 to 3e7377d Compare May 20, 2024 15:19
@anonrig anonrig disabled auto-merge May 20, 2024 16:00
@anonrig anonrig force-pushed the anonrig/more-and-more-orjson branch from 3e7377d to 6bf3625 Compare May 20, 2024 16:02
@anonrig anonrig enabled auto-merge (squash) May 20, 2024 16:02
@anonrig anonrig merged commit 1ca5470 into master May 20, 2024
48 checks passed
@anonrig anonrig deleted the anonrig/more-and-more-orjson branch May 20, 2024 16:30
@phacops phacops added the Trigger: Revert add to a merged PR to revert it (skips CI) label May 20, 2024
@getsentry-bot
Copy link
Contributor

PR reverted: 191f282

getsentry-bot added a commit that referenced this pull request May 20, 2024
@getsentry-bot @phacops
Revert "perf: move interfaces and integrations to orjson (#71055)"
191f282 
This reverts commit 1ca5470.

Co-authored-by: phacops <336345+phacops@users.noreply.github.com>
anonrig added a commit that referenced this pull request May 20, 2024
@anonrig
Reapply "perf: move interfaces and integrations to orjson (#71055)"
34cdf9c 
This reverts commit 191f282.
cmanallen pushed a commit that referenced this pull request May 21, 2024
@anonrig @cmanallen
perf: move interfaces and integrations to orjson (#71055)
12bb496 
Part of `orjson` move to get rid of `sentry.utils.json`
cmanallen pushed a commit that referenced this pull request May 21, 2024
@getsentry-bot @phacops @cmanallen
Revert "perf: move interfaces and integrations to orjson (#71055)"
122e458 
This reverts commit 1ca5470.

Co-authored-by: phacops <336345+phacops@users.noreply.github.com>
anonrig added a commit that referenced this pull request May 21, 2024
@anonrig
Reapply "perf: move interfaces and integrations to orjson (#71055)"
dacfa8b 
This reverts commit 191f282.
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iambriccardo iambriccardo iambriccardo approved these changes

@asottile-sentry asottile-sentry asottile-sentry approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components Trigger: Revert add to a merged PR to revert it (skips CI)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@anonrig @getsentry-bot @iambriccardo @asottile-sentry @phacops