Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(performance): Update queues module samples panel to support displaying producer samples. #70637

Merged
merged 3 commits into from May 13, 2024
Merged

feat(performance): Update queues module samples panel to support displaying producer samples. #70637

merged 3 commits into from May 13, 2024

Conversation

edwardgou-sentry
Copy link
Contributor

Updates samples panel to support both consumer and producer samples and fixes some minor ui bugs in samples panel.

@edwardgou-sentry
Updates samples panel to support both consumer and producer samples a…
27cf699 
…nd fixes some minor ui bugs in samples panel
@github-actions github-actions bot added the Scope: Frontend Automatically applied to PRs that change frontend components label May 10, 2024
@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review May 10, 2024 02:32
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner May 10, 2024 02:32
gggritso
gggritso approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@gggritso gggritso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! A few nits

static/app/views/performance/queues/messageSamplesPanel.tsx Outdated Show resolved Hide resolved
static/app/views/performance/queues/messageSamplesPanel.tsx Show resolved Hide resolved
static/app/views/performance/queues/messageSamplesPanel.tsx Outdated Show resolved Hide resolved
static/app/views/performance/queues/messageSamplesPanel.tsx Outdated Show resolved Hide resolved
@edwardgou-sentry edwardgou-sentry merged commit c0e4900 into master May 13, 2024
42 checks passed
@edwardgou-sentry edwardgou-sentry deleted the egou/feat/queues-module-producer-samples-panel branch May 13, 2024 22:34
@sentry-io Sentry.io
Copy link

sentry-io bot commented May 15, 2024 •
edited

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ Error: useNavigate() may be used only in the context of a component. useNavigate(useNavigate.tsx) View Issue
  • ‼️ Error: useLocation() may be used only in the context of a component. useLocation(useLocation.tsx) View Issue
  • ‼️ Error: �[2mexpect(�[22m�[31mjest.fn()�[39m�[2m).�[22mtoHaveBeenCalledWith�[2m(�[22m�[32m...expected�[39m... Object.?(messageSpanSamplesPanel.spec.tsx) View Issue
  • ‼️ Error: �[2mexpect(�[22m�[31mjest.fn()�[39m�[2m).�[22mtoHaveBeenCalledWith�[2m(�[22m�[32m...expected�[39m... Object.?(messageSpanSamplesPanel.spec.tsx) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gggritso gggritso gggritso approved these changes

Assignees
No one assigned
Labels
Scope: Frontend Automatically applied to PRs that change frontend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edwardgou-sentry @gggritso