fix(highlights): Fix crashing on null tag keys #70364
Conversation
github-actions
bot
added
the
Scope: Frontend
| if (!defined(tag.key)) { | ||
| return tree; | ||
| } |
There was a problem hiding this comment.
shouldn't the backend api which is producing garbage be fixed instead? this just hides the bug
There was a problem hiding this comment.
There might be a valid reason for these null keys even if I wasn't able to replicate it or test with it myself, it would be hasty to make changes like that since this UI is behind a flag and the previous UI had no issues -- It has been receiving null keys for some time, it'd seem.
This error was triggered from an EA group accessing a new interface I built for the frontend, so this fix provides the best compatibility with users who don't have access to the flags, without changing their experience of the legacy UI.
I will look into where the null keys come from to make sure we can account for it in the new UI, but for now I find this to be the best approach.
There was a problem hiding this comment.
have you looked into what's causing the null? I really think we should be striving for quality here instead of hacking around our own bugs in the frontend
There was a problem hiding this comment.
Spent a while investigating. The null values seem to come from invalid keys set for tags in the user's SDK. Things like /, \n or emoji. I created an issue to track the root cause separately.
I'd appreciate getting unblocked this to allow users to use their issues page. We can prioritize the root cause fix when appropriate.
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Resolves https://sentry.sentry.io/issues/5243747663/?project=11276
Not sure why tags are coming in with
nullorundefinedkeys, but we can't display those so they will be omitted, letting the rest of the component render as per usual.Also adding the team as a codeowner to help assignment for this stuff.