feat(metric-stats): Add cardinality limited outcome id #68422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Scope: Frontend
|
🚨 Warning: This pull request contains Frontend and Backend changes! It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently. Have questions? Please ask in the |
Bundle ReportChanges will increase total bundle size by 82 bytes ⬆️
|
iker-barriocanal
approved these changes
Apr 9, 2024
c298lee
pushed a commit
that referenced
this pull request
Apr 12, 2024
This adds a new outcome id for metric cardinality limits. A cardinality limited is similar to rate limits but instead of being enforced on volume (rate) it enforces cardinality. As well as quotas a metric can be subject to multiple cardinality limits, the limit id is noted in the reason field. The new id will only be emitted for the `METRIC_BUCKET` data category for now, which is unused throughout the product except for (abuse-)quotas.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new outcome id for metric cardinality limits. A cardinality limited is similar to rate limits but instead of being enforced on volume (rate) it enforces cardinality. As well as quotas a metric can be subject to multiple cardinality limits, the limit id is noted in the reason field.
The new id will only be emitted for the
METRIC_BUCKETdata category for now, which is unused throughout the product except for (abuse-)quotas.Loosely related to getsentry/relay#3147