New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(ingest): add DLQ tests for txns and attachments and DLQ support for attachments #67495
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #67495 +/- ##
===========================================
+ Coverage 47.37% 79.36% +31.98%
===========================================
Files 1840 6370 +4530
Lines 118052 282227 +164175
Branches 21321 48564 +27243
===========================================
+ Hits 55932 223992 +168060
+ Misses 62120 57795 -4325
- Partials 0 440 +440
|
Looks good to me. I'll let @lynnagara determine if the DLQ implementation is correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
No description provided.