Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replays): Drop and log click events with negative node-ids #66993

Merged
merged 3 commits into from Mar 15, 2024

Conversation

cmanallen
Copy link
Member

@cmanallen cmanallen commented Mar 14, 2024

Negative node-ids can't be inserted into our database because of type issues. Let's drop them for now. We'll also log them so we can figure out if they're important (and possibly debug an SDK issue).

@cmanallen cmanallen requested a review from a team as a code owner March 14, 2024 19:16
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 14, 2024
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.27%. Comparing base (7f57781) to head (cac856f).
Report is 37 commits behind head on master.

❗ Current head cac856f differs from pull request most recent head 54e1c7f. Consider uploading reports for the commit 54e1c7f to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #66993      +/-   ##
==========================================
- Coverage   84.27%   84.27%   -0.01%     
==========================================
  Files        5306     5306              
  Lines      237276   237238      -38     
  Branches    41045    41034      -11     
==========================================
- Hits       199971   199938      -33     
+ Misses      37087    37082       -5     
  Partials      218      218              
Files Coverage Δ
src/sentry/replays/usecases/ingest/dom_index.py 91.51% <100.00%> (+0.21%) ⬆️

... and 16 files with indirect coverage changes

Copy link
Member

@JoshFerge JoshFerge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we add a quick test with a negative node id?

@cmanallen cmanallen enabled auto-merge (squash) March 15, 2024 16:04
@cmanallen cmanallen merged commit 3ed1872 into master Mar 15, 2024
48 checks passed
@cmanallen cmanallen deleted the cmanallen/replays-log-negative-nodes branch March 15, 2024 16:30
JonasBa pushed a commit that referenced this pull request Mar 17, 2024
Negative node-ids can't be inserted into our database because of type
issues. Let's drop them for now. We'll also log them so we can figure
out if they're important (and possibly debug an SDK issue).
@github-actions github-actions bot locked and limited conversation to collaborators Mar 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants