dev: Fix schema validation in devserver #66715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lynnagara
commented
Mar 11, 2024
| @@ -100,7 +100,7 @@ def get_test_stream_processor( | |||
| max_poll_interval_ms=None, | |||
| enable_dlq=False, | |||
| healthcheck_file_path=None, | |||
| validate_schema=False, | |||
| enforce_schema=True, | |||
There was a problem hiding this comment.
We may as well always enforce this in tests
github-actions
bot
added
the
Scope: Backend
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #66715 +/- ##
========================================
Coverage 84.29% 84.30%
========================================
Files 5306 5308 +2
Lines 237154 237301 +147
Branches 41016 41043 +27
========================================
+ Hits 199916 200062 +146
- Misses 37019 37020 +1
Partials 219 219
|
jjbayer
approved these changes
Mar 12, 2024
Swatinem
approved these changes
Mar 12, 2024
untitaker
approved these changes
Mar 12, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures schema validation is run on every message on topics where a schema is registered in the devserver. The goal of this change is to help catch invalid messages in dev before changes are deployed.