Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove references to deprecated settings #66355

Merged
merged 1 commit into from Mar 6, 2024

Conversation

lynnagara
Copy link
Member

settings.KAFKA_OUTCOMES and settings.KAFKA_OUTCOMES_BILLING are deprecated and will be removed soon

settings.KAFKA_OUTCOMES and settings.KAFKA_OUTCOMES_BILLING are
deprecated and will be removed soon
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 5, 2024
Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.07%. Comparing base (f64a976) to head (312d036).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #66355      +/-   ##
==========================================
- Coverage   84.29%   83.07%   -1.23%     
==========================================
  Files        5309     5309              
  Lines      237208   237192      -16     
  Branches    41035    41036       +1     
==========================================
- Hits       199959   197051    -2908     
- Misses      37030    39921    +2891     
- Partials      219      220       +1     
Files Coverage Δ
src/sentry/testutils/pytest/kafka.py 94.93% <ø> (+8.12%) ⬆️
src/sentry/utils/outcomes.py 100.00% <100.00%> (ø)

... and 260 files with indirect coverage changes

@lynnagara lynnagara merged commit 3346844 into master Mar 6, 2024
50 checks passed
@lynnagara lynnagara deleted the outcomes-kafka-topics branch March 6, 2024 22:49
aliu3ntry pushed a commit that referenced this pull request Mar 6, 2024
settings.KAFKA_OUTCOMES and settings.KAFKA_OUTCOMES_BILLING are
deprecated and will be removed soon
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants