Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref: Remove old style topic definition from ingest consumer code #66352

Merged
merged 1 commit into from Mar 6, 2024
Merged

ref: Remove old style topic definition from ingest consumer code #66352

merged 1 commit into from Mar 6, 2024

Conversation

lynnagara
Copy link
Member

settings.KAFKA_INGEST_EVENTS, settings.KAFKA_INGEST_ATTACHMENTS and settings.KAFKA_INGEST_TRANSACTIONS are deprecated and will be removed.

@lynnagara
ref: Remove old style topic definition from ingest consumer code
16443e7 
settings.KAFKA_INGEST_EVENTS, settings.KAFKA_INGEST_ATTACHMENTS and
settings.KAFKA_INGEST_TRANSACTIONS are deprecated and will be removed.
@lynnagara lynnagara requested a review from a team as a code owner March 5, 2024 20:13
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Mar 5, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.30%. Comparing base (f9c2ffd) to head (16443e7).
Report is 7 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #66352   +/-   ##
=======================================
  Coverage   84.30%   84.30%           
=======================================
  Files        5309     5309           
  Lines      237200   237188   -12     
  Branches    41035    41031    -4     
=======================================
- Hits       199960   199955    -5     
+ Misses      37021    37014    -7     
  Partials      219      219
Files Coverage Δ
src/sentry/ingest/types.py 100.00% <ø> (+33.33%) ⬆️

... and 9 files with indirect coverage changes

@lynnagara lynnagara merged commit fec4728 into master Mar 6, 2024
50 checks passed
@lynnagara lynnagara deleted the ref-ingest-consumer-topics branch March 6, 2024 18:28
aliu3ntry pushed a commit that referenced this pull request Mar 6, 2024
@lynnagara @aliu3ntry
ref: Remove old style topic definition from ingest consumer code (#66352
300a604 
)

settings.KAFKA_INGEST_EVENTS, settings.KAFKA_INGEST_ATTACHMENTS and
settings.KAFKA_INGEST_TRANSACTIONS are deprecated and will be removed.
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

@victoria-yining-huang victoria-yining-huang victoria-yining-huang approved these changes

Assignees
No one assigned
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lynnagara @iker-barriocanal @victoria-yining-huang