Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

馃 Resolve KeyError for missing 'event_id' #66344

Closed
wants to merge 2 commits into from
Closed

馃 Resolve KeyError for missing 'event_id' #66344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa229ff
Fix KeyError by adding default values and logging for missing keys
sentry-autofix-experimental[bot] Mar 5, 2024
d5cf775
Add preliminary check for 'event_id' and 'project' in the store method
sentry-autofix-experimental[bot] Mar 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/sentry/eventstore/processing/base.py
View file
Open in desktop
Expand Up @@ -38,6 +38,9 @@ def exists(self, event: Event) -> bool:
return self.get(key) is not None

def store(self, event: Event, unprocessed: bool = False) -> str:
if not event.get('event_id') or not event.get('project'):
logger.error(f\"store method called with event missing 'event_id' or 'project'. Event data: {event}\")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if we have a policy around logging every error event in the errors pipeline, but this seems risky

return
with sentry_sdk.start_span(op="eventstore.processing.store"):
key = cache_key_for_event(event)
if unprocessed:
Expand Down
8 changes: 6 additions & 2 deletions src/sentry/utils/cache.py
View file
Open in desktop
Expand Up @@ -40,5 +40,9 @@ def __get__(self, obj: Any, type: Any = None) -> T:
return value


def cache_key_for_event(data: Mapping[str, Any]) -> str:
return "e:{}:{}".format(data["event_id"], data["project"])
def cache_key_for_event(data: Mapping[str, Any]) -> str:
event_id = data.get('event_id', 'unknown_event_id')
project = data.get('project', 'unknown_project')
if event_id == 'unknown_event_id' or project == 'unknown_project':
logger.error(f\"cache_key_for_event called with missing data. event_id: {event_id}, project: {project}\")
return \"e:{}:{}'.format(event_id, project)