Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: DLQ unprocessable messages on ingest-events #66236

Merged
merged 13 commits into from Mar 15, 2024
Merged

feat: DLQ unprocessable messages on ingest-events #66236

merged 13 commits into from Mar 15, 2024

Commits on Mar 4, 2024

  1. feat: DLQ unprocessable messages on ingest-events 

    This PR attempts to be somewhat cautious about DLQing and not DLQ
anything that is even potentially retriable. This could be tweaked
later.

An alternative (and imo better) approach would be to validate the
schema of failed messages and only then put them into the DLQ.
However no schema is currently registered for this topic so this
cannot be done easily.
    @lynnagara
    lynnagara committed Mar 4, 2024
    Copy the full SHA
    7078a19 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. use schema to determine what to dlq

    @lynnagara
    lynnagara committed Mar 6, 2024
    Copy the full SHA
    9e31d5d View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2024

  1. Merge branch 'master' into ingest-events-dlq

    @lynnagara
    lynnagara committed Mar 8, 2024
    Copy the full SHA
    9a784be View commit details
    Browse the repository at this point in the history

  2. fix topic

    @lynnagara
    lynnagara committed Mar 8, 2024
    Copy the full SHA
    e71b3fb View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2024

  1. Merge branch 'master' into ingest-events-dlq

    @lynnagara
    lynnagara committed Mar 11, 2024
    Copy the full SHA
    f278266 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2024

  1. add test, also raise if encoding is wrong

    @lynnagara
    lynnagara committed Mar 12, 2024
    Copy the full SHA
    c93b85c View commit details
    Browse the repository at this point in the history

  2. improve test and fix bug

    @lynnagara
    lynnagara committed Mar 12, 2024
    Copy the full SHA
    3926556 View commit details
    Browse the repository at this point in the history

Commits on Mar 14, 2024

  1. Merge branch 'master' into ingest-events-dlq

    @lynnagara
    lynnagara committed Mar 14, 2024
    Copy the full SHA
    6f630d6 View commit details
    Browse the repository at this point in the history

  2. feedback events

    @lynnagara
    lynnagara committed Mar 14, 2024
    Copy the full SHA
    ab4b4a0 View commit details
    Browse the repository at this point in the history

  3. add back retriable exception

    @lynnagara
    lynnagara committed Mar 14, 2024
    Copy the full SHA
    52351dd View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' into ingest-events-dlq

    @lynnagara
    lynnagara committed Mar 14, 2024
    Copy the full SHA
    3588f20 View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2024

  1. Merge branch 'master' into ingest-events-dlq

    @lynnagara
    lynnagara committed Mar 15, 2024
    Copy the full SHA
    2bf612a View commit details
    Browse the repository at this point in the history

  2. test

    @lynnagara
    lynnagara committed Mar 15, 2024
    Copy the full SHA
    6550ee1 View commit details
    Browse the repository at this point in the history