…re flag (#66257)

removes flag declaration and all refs
getsentry/team-replay#387

Was using TSResult here which is wrong, it's a dict w/ data or a dict of
dicts if it's a group-by. The presence of the data key should be
indicative.

Fixes SENTRY-2V84

### Summary
If there are any problems with the split decision this will cause it to
always re-run the code and save the new decision,

<img width="1035" alt="Screenshot 2024-03-03 at 9 36 22 PM"
src="https://github.com/getsentry/sentry/assets/60121741/860a6370-b1aa-41dc-b5c8-b62b9778ffa5">

---------

Co-authored-by: Abdullah Khan <abdullahkhan@PG9Y57YDXQ.local>

This PR adds the current user to the header of the replay in the issue
details page:

Before:
![Screenshot 2024-03-04 at 1 15
37 PM](https://github.com/getsentry/sentry/assets/8533851/614047aa-e0da-4520-91d0-5d71f22f8cd9)


After:
![Screenshot 2024-03-04 at 1 15
31 PM](https://github.com/getsentry/sentry/assets/8533851/4592b55d-ac83-4448-8af5-06988dfc5aa1)

…or environment (#66265)

These constraints are causing migrations to fail in getsentry, where
we've set up the router to move these tables to a separate database.

We need to support deleted fields on Django model schemas for a number
of self-hosted released (currently 2). This means that even if we delete
a field on HEAD, we still need to make the import script aware that the
field could exit on imported JSON, and pre-process that JSON in such a
way that the field is removed in cases where the JSON was generated by
an old version that still contained the field.

There is no purpose in testing this code standalone. It passes tests in
#65923, which is the first actual use of this shimming mechanism.

Just moving 3 consumers as a first step, will migrate the rest as a
follow up

#66277)

Toggles off INP

failure_issue_threshold will never be falsey due because of this
condition here [0]

[0]:
https://github.com/getsentry/sentry/blob/11e039354141a8487776be19d7535d0da2ee53ce/src/sentry/monitors/logic/mark_failed.py#L44-L45

This is the second step following #66206:

Step 2 of removing outdated tables and columns from the
`ArtifactBundleIndex` involves removing them from the migration state
*only*.

Actual removal from SQL follows in a third step.

Remove normalization logic from FE.

- closes #65765

…llelize (#66298)

* Use spanId for identifying chart samples
* Wrap widget with error boundary
* Fix query response meta type

Instead of using a Redis-based lock to protect concurrent `FileBlob`
uploads and deletes, the code was already changed previously to handle
the cases of concurrent uploads, as well as to reduce the likelihood of
concurrent deletes by regularly bumping the `FileBlob` timestamp.

The lock has been disabled via an `option` recently, and now it is time
to completely remove this code.

Extracted from #66229 as a first step. The `MetricReadout` component
represents a single metric block in our various Starfish metrics
ribbons.

This component has some advantages over using plain `Block`s:

- consistent loading state
- consistent missing data state
- built-in support for different kinds of units
- built-in simple support for tooltips

This makes it easy to use it in all kinds of contexts.

These are changes necessary to run `sentry` with the Python SDK 2.0.0a2.

Three tests are still failing and I commented them out to be able to
test this on S4S and Canary.

The package `pytest-sentry` is not yet compatible to SDK 2.0, we will
release an updated version of it soon. After this has been released we
can upgrade `sentry` to SDK 2.0 for good.

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Co-authored-by: Francesco Vigliaturo <francesco.vigliaturo@sentry.io>
Co-authored-by: ArthurKnaus <arthur.knaus@sentry.io>

### Summary
Missed that the inner block was also getting `data` as if it was an
attribute.

Fixes SENTRY-2VPR

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

This reverts commit b9b433b.

Co-authored-by: antonpirker <202325+antonpirker@users.noreply.github.com>

`measurements.inp` should point to `d:spans/webvital.inp@millisecond`

This reverts commit e968207.

Co-authored-by: edwardgou-sentry <83961295+edwardgou-sentry@users.noreply.github.com>

…66309)

This was querying all profiles accidentally without the transaction
condition.

This is part of the effort to port proguard processing to Symbolicator
(getsentry/team-processing#116). In
particular, it hooks into the new `symbolicate-jvm` endpoint introduced
in getsentry/symbolicator#1393.

When we add regions we need a way to keep the region out of UI
interactions and the public API responses until it has been validated.

The `find_all_multitenant_region_names` method is used in sentry and
getsentry to get the list of multi-tenant regions that are available for
new account creation.

Once we have a new region functionally working it can be made visible.
Even after a region is visible account creation would be gated by
feature flags.

Just a quick padding fix on the resource page, nothing fancy.

Before

![image](https://github.com/getsentry/sentry/assets/44422760/ff0097a0-5309-43e1-bea3-744daf827e28)


After

![image](https://github.com/getsentry/sentry/assets/44422760/4e0adbfc-87f6-48cd-bb6a-9acae370a3dc)

…ion (#66317)

bumps js sdk to 7.103.0 and updates browsertracingintegration

This column is called `profile.id` on other datasets. Not sure why it's
called `profile_id` here. Especially when all other id columns in this
dataset uses the dot notation. Keeping `profile_id` around for
compatibility.

---------

Co-authored-by: William Mak <william@wmak.io>

Fixes #65071

Directs users with no HTTP span to the "Set Up Performance" page rather
than the "Integrations" page which doesn't even exist for a lot of
platforms.

…per (#66168)

We need to shift the reprocessing workload to a new redis cluster
without downtime. In order to do that I would like to use our Service
wrappers and ServiceDelegator to dual write and then shift reads via
runtime options.

Before I can move load with ServiceDelegator the existing logic needs to
be moved into a service wrapper.

Change the get_aggregation_options to return a dictionary of options,
and
associate the options with a time window.

This is precursor work to being able to check the aggregation options
when
querying, to ensure queries are not asking using options that are not
available.

While implementing monitor incidents there was a period of time where we
were "cutting over" to monitors creating incident entities instead of
just producing issue occurrences where the grouphash was computed from
an interim 'last_state_change'. All monitors are now producing incidents
when they fail, so we no longer need the fallback grouphash computation

The `last_state_change` was only required for this interim period and
will also be removed in a future commit.

Fixes SENTRY-2VF1 and SENTRY-2VF2

…emove unresolved tab (#66269)

…ides (#66283)

This moves the `dlq_topic` consumer definitions and anything that uses
the `get_topic_definition` helper function over to the new style kafka
topic config.

…ds array (#66275)

Updates useIndexedSpans to accept an optional fields array to allow
selecting specific fields.
Refactors existing call to use new function signature.

https://github.com/getsentry/sentry/assets/56095982/e3ee988f-893a-4f5d-b8e7-827e12291a40

Also adjusts the stream column width since we don't need as much space
any longer

Depends on #66283

The no value message is quite long so use a disabled button for it to
appear more compact.

)

Changed snippet example to `colorScheme: "system"`:
<img width="457" alt="SCR-20240305-jdjj"
src="https://github.com/getsentry/sentry/assets/56095982/fe99f6aa-8b3e-4ed6-b117-15cacf9273dd">

Updated links and hyperlink to the specific "bring your own button"
section in the docs:
<img width="465" alt="SCR-20240305-jcve"
src="https://github.com/getsentry/sentry/assets/56095982/2a9984a4-4947-437c-bcc5-b93d991a70b9">

With #65346 and
getsentry/getsentry#12983 merged, self-hosted
and all organizations on SaaS now have access to the commit-context
feature for suspect commits. The feature flag can be safely removed.

This code is no longer needed now that we have stopped generating legacy
event hashes in GH-66250

…#66266)

### Overview

Update indexer telemetry to handle no messages in case everything is
killswitched

…iew (#66346)

Fixes #66322

The existing styles were too similar to the highlighted line color.
Using browser default coloring works well enough.

#66327)

Follow up of
https://github.com/getsentry/sentry/pull/66250/files#r1512012737

<img width="459" alt="SCR-20240305-lrbx"
src="https://github.com/getsentry/sentry/assets/56095982/90706ed5-cf5d-4996-a9e1-79b94f38e7d2">

…nd overrides (#66283)"

This reverts commit f7ffe5a.

Co-authored-by: ayirr7 <47572810+ayirr7@users.noreply.github.com>

…66287)"

This reverts commit f9c2ffd.

Co-authored-by: IanWoodard <17186604+IanWoodard@users.noreply.github.com>

This is no longer needed after usage removal in GH-66328

[per
discussions](https://sentry.slack.com/archives/C06J6HKFKLG/p1708464708399359)

bumping the 'more slow alerts' group to 300 alerts.

This is a temporary fix and will need to be addressed properly
(potentially via
[inc-666](https://getsentry.atlassian.net/browse/INC-666), but there may
be other solutions here as well)

Includes feature flag and monitor type validator in the alert rule api
serializer

Serializer converts int value into enum

Add a log line when we send the notification as I'm doing internal
testing.

…dropdown (#66362)

Just some minor re-organiztion to make it a bit more readible

<img width="687" alt="SCR-20240305-ihne"
src="https://github.com/getsentry/sentry/assets/187460/e15745d8-ea24-4ce6-a2ec-858a6c50d1b8">

Used for debugging race conditions of when we create the row vs when we
check for it

…th a slug already exists in the target org (#66340)

There are 4 monitors that exist twice in the same project, but in
different orgs. The ones that have a different org than the project's
org are totally broken and can't receive checkins. We'll just delete
them, they're inaccessible at the moment.

…66358)

Debug logging

accidentally had two `native` platforms in this list

)

Fixes #58573,
#48480

Previously, objects/arrays were only collapsible after they reached
maxDefaultDepth. The major change here is that now each level is
collapsible

- Each level is now always collapsible. Before, objects/arrays were only
collapsible after a certain depth
- Arrays/objects begin collapsed when there are more than 5 items, in
addition to when they are at a certain depth
- Changed the appearance and location of the toggle buttons to better
match commonly-used json viewers
- Added `n items` preview text for collapsed objects/arrays (which is
clickable!)

Brings back #66283 with fixes to
the indexer strategy. It crashed on the prior deploy as we were not
producing to the correctly resolved topic.

…is (#66388)

<!-- Describe your PR here. -->

Remove request duplication logic for metrics meta queries to utilize
parallelization on the BE and unblock other requests in the browser.

New PR for another load test to check performance of the new Python SDK
2.0

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

This reverts commit 51ae02e.

Co-authored-by: antonpirker <202325+antonpirker@users.noreply.github.com>

Workaround as the endpoint returns empty series for groups that are
excluded by a filter.

This is the third step, following
#66206 and
#66207:

In step 3, we fully drop the obsolete columns and tables after they have
been removed from the migration state in prior steps.

Allow toggling queries from being displayed by clicking their query
symbol.


- closes #66201

Along the way of bumping dependencies, some tests are fixed to cover for
the changes in Relay.

…otification (#66113)

Complete work started in #65736, #65791, and #65883 to remove a
parameter from the send_incident_alert_notification RPC method.

Fixes HC-1123
Fixes SENTRY-2QAG

Follow up on a TODO that has triggered an error. Add tests so that
future maintenance on the bitbucket integration is a bit easier.

Fixes SENTRY-2TNS

Add logging when we have a bad request from an RPC method. We don't
often get sentry errors from these failures, and not being able to see
the response of these operations makes debugging harder.

This adds a feature flag to allow support of mobile replay player.
Currently for internal testing only

As we set up the application logic to run performance issue detection
on standalone spans, we want to collect metrics to check if transaction
based and span based perf issue detection are equivalent. Tagging
metrics with `is_standalone_spans` to track this.
This also updates fingerprint so the standalone span occurrences 
don't get grouped with existing perf issues during testing.

We have fully enabled these, so lets remove all the options usage
related to it.

This is pretty much a followup from #65533.

…ics ingestion to vroom (#66300)

This PR fixes two bugs. Firstly, if a user passed an MQL string into the
layer
(which is completely valid) the layer would throw an exception.

Secondly, if a formula had a component that was itself a formula of
scalars,
e.g. sum(x) + (7 * 24), an exception would be thrown.

Add sentry_region to the tags of errors/transactions we collect. This
helps with diagnosing which region an error is occurring in. Previously
we were planning on using `environment` for this but it would have
required a non-trivial amount of monitoring changes. The `sentry_region`
name mirrors the tag used in other monitoring tools we use.

Just some very very basic content to get some content and routing up.

…integration (#66317)"

This reverts commit f4c4978.

Looking for the reason for the drop in pageloads.

…66118)

- DDM, Replays, and Feedback onboarding were all using some variation of
this hook: `useCurrentProjectState`. They're all pretty similar, so I
refactored them into one general reusable hook
- I modified the respective `sidebar.tsx` files to use this new hook
- I also added a hook test

…lized (#66118)"

This reverts commit 03677ee.

Co-authored-by: michellewzhang <56095982+michellewzhang@users.noreply.github.com>

…ts (#66151)

(This feature is in LA) 

Whitelisted php projects for automatic code mapping support and added
unit tests

---------

Co-authored-by: Bartek Ogryczak <bartek.ogryczak@sentry.io>
Co-authored-by: Armen Zambrano G. <44410+armenzg@users.noreply.github.com>

…66425)

- had to revert the original PR
(#66118) due to a failing test -
fixed in this PR! this is the only change from the previous PR
- DDM, Replays, and Feedback onboarding were all using some variation of
this hook: `useCurrentProjectState`. They're all pretty similar, so I
refactored them into one general reusable hook
- I modified the respective `sidebar.tsx` files to use this new hook
- I also added a hook test

The bounding boxes right now always bound the metric on the min/max. But
depending on the operation, we should look at different values to bound
determine if it lies in the bounding box. For example, if graphing the
min, we should ensure the min is with in the bounding box.

There's a bug where we're no longer requiring superuser access category
and reason validation, which is caused by
https://github.com/getsentry/sentry/pull/66043/files.

I want to validate what those booleans are in order to find out if this
is the cause of the bug.

Adds `span.op` to `DEFAULT_METRIC_TAGS` so that it is available in
discover metrics queries.

…tab (#66374)

From a rage click issue, "see full replay" takes you to the breadcrumbs
tab with the rage & dead click filter selected.

Relates to getsentry/team-replay#394. Temp
solution until we can load in rage click issues to the errors tab


https://github.com/getsentry/sentry/assets/56095982/cda9511d-8458-4fc4-a506-0b36ed217d51

Another refactor peeled away from #66229. The `SpanMetricsRibbon`
component is used in two places:

1. The top right of the Query Summary page
2. The completely unused generic span summary page

The ribbon is a little silly because it supports just these two use
cases! This is much better done using the new `MetricReadout` by using
it directly in the parent. No visual changes.

)

settings.KAFKA_INGEST_EVENTS, settings.KAFKA_INGEST_ATTACHMENTS and
settings.KAFKA_INGEST_TRANSACTIONS are deprecated and will be removed.

…66351)

- add a sidebar popup when "set up now" is clicked
- add crash report modal onboarding config for javascript with widget
callout

<img width="1072" alt="SCR-20240305-ocgr"
src="https://github.com/getsentry/sentry/assets/56095982/a9b92ffb-7ea0-4bd7-83b0-299e3ae2a2fe">

- I messed up the name of the project option in the endpoint, it should
be plural, not singular
- I was using the wrong project option flag in the check 🤦‍♂️

Thank you to @jas-kas for catching this bug. 🙏🏼 this is what EA is for!


I do want to refactor project options to make it easier to test // less
prone to bugs when adding additional ones. will add a TODO item.

We've rolled out rage click_creation_with_replay_event, so we can remove
this celery task and the usages of it. huzzah!

https://sentry.sentry.io/dashboard/77863/?project=1&statsPeriod=24h
(can see bottom metric has dropped to zero, while one to left has gone
up).

this represents that now the new function is being called 100% of the
time so we can remove this code.

- Add urllib3 errors to the query handler
- Mostly downstream hiccups in either case
- Fixes SENTRY-2W3A
- Fixes SENTRY-2TE9
- Fixes SENTRY-2VVR
- Fixes SENTRY-2JBW

- This was missing a handle_query_errors so exceptions were bubbling up
too high
- Fixes SENTRY-2KVM

Spun off from: #65963

- adds a missing children prop, swaps ReactElement to ReactNode
- removes a render function used as a child

As we transition to a state where monitor slugs are unique to the
project and not the org, we need to have project slug information in the
crons listing page to differentiate duplicate cron slugs within an org.

<img width="1246" alt="image"
src="https://github.com/getsentry/sentry/assets/9372512/f31e4f75-cdc0-41d3-820e-a2928562fe73">

If the project + schedule text gets too long, then it wraps to the next
line. We have a good amount of space in the details area so opted for
wrapping vs. ellipsizing

No longer needed after GH-66353

…ry for INP measurements (#66421)

Updates all metrics based queries in the Web Vitals module to properly
query for INP measurements and aggregates.
We previously subbed in FID metrics for INP for testing/development
purposes. This PR removes that since INP is now properly queryable in
Discover.

…ow to properly account for weights from different score profiles (#66434)

Update calculatePerformanceScoreFromStoredTableDataRow to properly
account for weights from different score profiles

To give the illusion of a consistent paging, we take the hash of the
limit and offset as the seed to `groupArraySample`.

…rt and updates tooltip to label as deprecated (#66438)

Greys out FID in the performance score breakdown chart and updates
tooltip to label as deprecated

…port displaying inp (#66439)

updates webvitals landing page slideout panel to support displaying inp

### Summary
We're bumping again since we've determined that pageloads are now lower
due to inheriting the sampling decision from the sentry project, along
with the release, public key and transaction name potentially changing

…66447)

catch KafkaExceptions here, as we shouldn't crash the task. Can follow
up with diagnosing the KAFKA_TOO_LARGE payloads and making an upstream
fix.

Should also determine if we should catch this logic in the occurrence
production code instead, so other upstream places don't crash because of
this.

FIxes https://sentry.sentry.io/issues/5040716121/

currently the incidents/models.py file is nearly 1k lines long and the
file name `model` does not do much to tell us what it's contents are

PR to split up the file names and directory

edit:

oh lawd. i swear most of these are modifying imports now that the
directory structure has been modified

Resolves getsentry/getsentry#13170
Requires getsentry/getsentry#13170

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

- If fields had `-` in them the query would fail since we weren't
resolving the column to a tag correctly
- Fixes: SENTRY-2W5S

- Fixes SENTRY-2VV0
- Fixes a bug where we were saying errors supports top events even
though it doesn't

* Just the allowlist part of the API Pagination Check
* Need to break down the larger PR because adding `requires` in the PR
description doesn't seem to be working

Let's centralize this here, no need for callers to need to think about
this detail

---------

Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>

Guard statments tend to be clearer

…6460)

Follow-up to #66447

Moves the handling down per comment, adds the size of the payload.

…rs (#65989)

this pr removes the feature flag for default inbound filters for new
javascript projects now that it is GA'ed

settings.KAFKA_OUTCOMES and settings.KAFKA_OUTCOMES_BILLING are
deprecated and will be removed soon