Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First invalid tag key causes weird tag on issue details #70388

Open
leeandher opened this issue May 6, 2024 · 0 comments
Open

First invalid tag key causes weird tag on issue details #70388

leeandher opened this issue May 6, 2024 · 0 comments

Comments

@leeandher
Copy link
Member

leeandher commented May 6, 2024

Environment

SaaS (https://sentry.io/)

Steps to Reproduce

  1. Set two invalid tag key in the SDK:
sentry_sdk.set_tag('slash/1', 'some-value')
sentry_sdk.set_tag('slash/2', 'some-value-2')
  1. Cause an error
  2. Go to issue details for the page

Expected Result

Since those tags were invalid, I'd expect the keys and values to be dropped. They should both appear at the top of the page as invalid, and I wouldn't expect to see some-value or some-value-2 anywhere.

Actual Result

We only show an actionable call out for one of the dropped tags, even though both were omitted, and for some reason we retain the first error's value, causing us to display null: some-value.

image
image

I thought the bug could be in serialization, but in event.py, get_tags_with_meta fn, it appears to already save the event with a raw tag of [None, 'some-value'] meaning the bug takes place before that. I don't know why the second dropped tag is being omitted.

Product Area

Issues

Link

https://sentry-leander.sentry.io/issues/5312471138/?project=5900755&query=is%3Aunresolved&referrer=issue-stream&statsPeriod=30d&stream_index=0

DSN

No response

Version

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant