chore(inbound-filters): Remove feature flag for default inbound filte…

…rs (#65989)

this pr removes the feature flag for default inbound filters for new
javascript projects now that it is GA'ed

src/sentry/api/endpoints/team_projects.py

@@ -4,7 +4,7 @@
 from rest_framework.request import Request
 from rest_framework.response import Response
 
-from sentry import audit_log, features
+from sentry import audit_log
 from sentry.api.api_owners import ApiOwner
 from sentry.api.api_publish_status import ApiPublishStatus
 from sentry.api.base import EnvironmentMixin, region_silo_endpoint
@@ -182,11 +182,7 @@ def post(self, request: Request, team) -> Response:
             # XXX: create sample event?
 
             # Turns on some inbound filters by default for new Javascript platform projects
-            if (
-                features.has("organizations:default-inbound-filters", team.organization)
-                and project.platform
-                and project.platform.startswith("javascript")
-            ):
+            if project.platform and project.platform.startswith("javascript"):
                 set_default_inbound_filters(project, team.organization)
 
             self.create_audit_entry(

src/sentry/conf/server.py

@@ -1528,8 +1528,6 @@ def custom_parameter_sort(parameter: dict) -> tuple[str, int]:
     "organizations:ddm-dashboard-import": False,
     # Enable the default alert at project creation to be the high priority alert
     "organizations:default-high-priority-alerts": False,
-    # Enable inbound filters to be turned on by default for new Javascript Projects
-    "organizations:default-inbound-filters": False,
     # Enables automatically deriving of code mappings
     "organizations:derive-code-mappings": True,
     # Enables automatically deriving of PHP code mappings

src/sentry/features/__init__.py

@@ -89,7 +89,6 @@
 default_manager.add("organizations:dashboards-import", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
 default_manager.add("organizations:dashboards-mep", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
 default_manager.add("organizations:dashboards-rh-widget", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
-default_manager.add("organizations:default-inbound-filters", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
 default_manager.add("organizations:ddm-experimental", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
 default_manager.add("organizations:ddm-dashboard-import", OrganizationFeature, FeatureHandlerStrategy.REMOTE)
 default_manager.add("organizations:ddm-ui", OrganizationFeature, FeatureHandlerStrategy.INTERNAL)

tests/sentry/api/endpoints/test_team_projects.py

@@ -132,7 +132,6 @@ def test_without_default_rules(self):
         project = Project.objects.get(id=response.data["id"])
         assert not Rule.objects.filter(project=project).exists()
 
-    @with_feature("organizations:default-inbound-filters")
     def test_default_inbound_filters(self):
         filters = ["browser-extensions", "legacy-browsers", "web-crawlers", "filtered-transaction"]
         python_response = self.get_success_response(
@@ -184,7 +183,6 @@ def test_default_inbound_filters(self):
         assert javascript_filter_states["web-crawlers"]
         assert javascript_filter_states["filtered-transaction"]
 
-    @with_feature("organizations:default-inbound-filters")
     @with_feature("organizations:legacy-browser-update")
     def test_updated_legacy_browser_default(self):
         project_data = {"name": "foo", "slug": "baz", "platform": "javascript-react"}