Skip to content

feat(generic-metrics): Don't produce headers unnecessarily #100726

feat(generic-metrics): Don't produce headers unnecessarily

feat(generic-metrics): Don't produce headers unnecessarily #100726

Triggered via pull request March 21, 2024 21:59
Status Failure
Total duration 27m 17s
Artifacts

backend.yml

on: pull_request
detect what files changed
5s
detect what files changed
Matrix: backend migration tests
Matrix: backend test
Matrix: cli test
Matrix: check migration
api docs test
4m 0s
api docs test
requirements check
0s
requirements check
monolith-dbs test
7m 40s
monolith-dbs test
backend typing
5m 28s
backend typing
Backend
0s
Backend
Fit to window
Zoom out
Zoom in

Annotations

14 errors
backend test (6, 14): tests/sentry/sentry_metrics/test_batch.py#L790
test_resolved_with_aggregation_options AssertionError: assert [({'aggregati... 1, ...}, [])] == [({'aggregati...type', 's')])] At index 0 diff: ({'tags': {'3': 'production', '9': 'init'}, 'version': 2, 'retention_days': 90, 'mapping_meta': {'c': {'9': 'session.status', '1': 'c:transactions/alert@none', '3': 'environment'}}, 'use_case_id': 'transactions', 'metric_id': 1, 'org_id': 1, 'timestamp': 1711058601, 'project_id': 3, 'type': 'c', 'value': 1, 'sentry_received_timestamp': 1711058601.082724, 'aggregation_option': 'ten_second'}, []) != ({'mapping_meta': {'c': {'1': 'c:transactions/alert@none', '3': 'environment', '9': 'session.status'}}, 'metric_id': 1, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'tags': {'3': 'production', '9': 'init'}, 'timestamp': 1711058601, 'type': 'c', 'use_case_id': 'transactions', 'value': 1.0, 'aggregation_option': 'ten_second', 'sentry_received_timestamp': 1711058601.082724, 'version': 2}, [('mapping_sources', b'c'), ('metric_type', 'c')]) Full diff: [ ( { 'aggregation_option': 'ten_second', 'mapping_meta': { 'c': { '1': 'c:transactions/alert@none', '3': 'environment', '9': 'session.status', }, }, 'metric_id': 1, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 'production', '9': 'init', }, 'timestamp': 1711058601, 'type': 'c', 'use_case_id': 'transactions', - 'value': 1.0, ? -- + 'value': 1, 'version': 2, }, - [ - ( - 'mapping_sources', - b'c', - ), - ( - 'metric_type', - 'c', - ), - ], + [], ? + ), ( { 'aggregation_option': 'hist', 'mapping_meta': { 'c': { '2': 'd:transactions/measurements.fcp@millisecond', '3': 'environment', '9': 'session.status', }, }, 'metric_id': 2, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 'production', '9': 'healthy', }, 'timestamp': 1711058601, 'type': 'd', 'use_case_id': 'transactions', 'value': [ 4, 5, 6, ], 'version': 2, }, - [ - ( - 'mapping_sources', - b'c', - ), - ( - 'metric_type', - 'd', - ), - ], + [], ? + ), ( { 'aggregation_option': 'ten_second', 'mapping_meta': { 'c': { '3': 'environment', '8': 's:transactions/on_demand@none', '9': 'session.status', }, }, 'metric_id': 8, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 'production', '9': 'errored', }, 'timestamp': 1711058601, 'type': 's
backend test (6, 14): tests/sentry/sentry_metrics/test_batch.py#L941
test_all_resolved AssertionError: assert [({'mapping_m... 3, ...}, [])] == [({'mapping_m...type', 's')])] At index 0 diff: ({'tags': {'3': 7, '9': 6}, 'retention_days': 90, 'mapping_meta': {'c': {'1': 'c:sessions/session@none', '7': 'production', '9': 'session.status', '3': 'environment'}, 'h': {'6': 'init'}}, 'use_case_id': 'sessions', 'metric_id': 1, 'org_id': 1, 'timestamp': 1711058601, 'project_id': 3, 'type': 'c', 'value': 1, 'sentry_received_timestamp': 1711058601.082724}, []) != ({'mapping_meta': {'c': {'1': 'c:sessions/session@none', '3': 'environment', '7': 'production', '9': 'session.status'}, 'h': {'6': 'init'}}, 'metric_id': 1, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'tags': {'3': 7, '9': 6}, 'timestamp': 1711058601, 'type': 'c', 'use_case_id': 'sessions', 'value': 1.0, 'sentry_received_timestamp': 1711058601.082724}, [('namespace', b'sessions'), ('mapping_sources', b'ch'), ('metric_type', 'c')]) Full diff: [ ( { 'mapping_meta': { 'c': { '1': 'c:sessions/session@none', '3': 'environment', '7': 'production', '9': 'session.status', }, 'h': { '6': 'init', }, }, 'metric_id': 1, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 7, '9': 6, }, 'timestamp': 1711058601, 'type': 'c', 'use_case_id': 'sessions', - 'value': 1.0, ? -- + 'value': 1, }, - [ - ( - 'namespace', - b'sessions', - ), - ( - 'mapping_sources', - b'ch', - ), - ( - 'metric_type', - 'c', - ), - ], + [], ? + ), ( { 'mapping_meta': { 'c': { '2': 'd:sessions/duration@second', '3': 'environment', '7': 'production', '9': 'session.status', }, 'h': { '5': 'healthy', }, }, 'metric_id': 2, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 7, '9': 5, }, 'timestamp': 1711058601, 'type': 'd', 'use_case_id': 'sessions', 'value': [ 4, 5, 6, ], }, - [ - ( - 'namespace', - b'sessions', - ), - ( - 'mapping_sources', - b'ch', - ), - ( - 'metric_type', - 'd', - ), - ], + [], ? + ), ( { 'mapping_meta': { 'c': { '3': 'environment', '7': 'production', '8': 's:sessions/error@none', '9': 'session.status', }, 'd': { '4': 'errored', }, }, 'metric_id': 8, 'org_id': 1, 'project_id': 3, 'retent
backend test (6, 14): tests/sentry/sentry_metrics/test_batch.py#L1090
test_all_resolved_with_routing_information AssertionError: assert [({'org_id': ... 3, ...}, [])] == [({'org_id': ...type', 's')])] At index 0 diff: ({'org_id': 1}, {'tags': {'3': 7, '9': 6}, 'retention_days': 90, 'mapping_meta': {'c': {'1': 'c:sessions/session@none', '7': 'production', '9': 'session.status', '3': 'environment'}, 'h': {'6': 'init'}}, 'use_case_id': 'sessions', 'metric_id': 1, 'org_id': 1, 'timestamp': 1711058601, 'project_id': 3, 'type': 'c', 'value': 1, 'sentry_received_timestamp': 1711058601.082724}, []) != ({'org_id': 1}, {'mapping_meta': {'c': {'1': 'c:sessions/session@none', '3': 'environment', '7': 'production', '9': 'session.status'}, 'h': {'6': 'init'}}, 'metric_id': 1, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'tags': {'3': 7, '9': 6}, 'timestamp': 1711058601, 'type': 'c', 'use_case_id': 'sessions', 'value': 1.0, 'sentry_received_timestamp': 1711058601.082724}, [('namespace', b'sessions'), ('mapping_sources', b'ch'), ('metric_type', 'c')]) Full diff: [ ( { 'org_id': 1, }, { 'mapping_meta': { 'c': { '1': 'c:sessions/session@none', '3': 'environment', '7': 'production', '9': 'session.status', }, 'h': { '6': 'init', }, }, 'metric_id': 1, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 7, '9': 6, }, 'timestamp': 1711058601, 'type': 'c', 'use_case_id': 'sessions', - 'value': 1.0, ? -- + 'value': 1, }, - [ - ( - 'namespace', - b'sessions', - ), - ( - 'mapping_sources', - b'ch', - ), - ( - 'metric_type', - 'c', - ), - ], + [], ? + ), ( { 'org_id': 1, }, { 'mapping_meta': { 'c': { '2': 'd:sessions/duration@second', '3': 'environment', '7': 'production', '9': 'session.status', }, 'h': { '5': 'healthy', }, }, 'metric_id': 2, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 7, '9': 5, }, 'timestamp': 1711058601, 'type': 'd', 'use_case_id': 'sessions', 'value': [ 4, 5, 6, ], }, - [ - ( - 'namespace', - b'sessions', - ), - ( - 'mapping_sources', - b'ch', - ), - ( - 'metric_type', - 'd', - ), - ], + [], ? + ), ( { 'org_id': 1, }, { 'mapping_meta': { 'c': { '3': 'environment', '7': 'production', '8': 's:sessions/error@none', '9': 'session.status',
backend test (6, 14): tests/sentry/sentry_metrics/test_batch.py#L1255
test_all_resolved_retention_days_honored AssertionError: assert [({'mapping_m... 3, ...}, [])] == [({'mapping_m...type', 's')])] At index 0 diff: ({'tags': {'3': 7, '9': 6}, 'retention_days': 90, 'mapping_meta': {'c': {'1': 'c:sessions/session@none', '7': 'production', '9': 'session.status', '3': 'environment'}, 'h': {'6': 'init'}}, 'use_case_id': 'sessions', 'metric_id': 1, 'org_id': 1, 'timestamp': 1711058601, 'project_id': 3, 'type': 'c', 'value': 1, 'sentry_received_timestamp': 1711058601.082724}, []) != ({'mapping_meta': {'c': {'1': 'c:sessions/session@none', '3': 'environment', '7': 'production', '9': 'session.status'}, 'h': {'6': 'init'}}, 'metric_id': 1, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'tags': {'3': 7, '9': 6}, 'timestamp': 1711058601, 'type': 'c', 'use_case_id': 'sessions', 'value': 1.0, 'sentry_received_timestamp': 1711058601.082724}, [('namespace', b'sessions'), ('mapping_sources', b'ch'), ('metric_type', 'c')]) Full diff: [ ( { 'mapping_meta': { 'c': { '1': 'c:sessions/session@none', '3': 'environment', '7': 'production', '9': 'session.status', }, 'h': { '6': 'init', }, }, 'metric_id': 1, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 7, '9': 6, }, 'timestamp': 1711058601, 'type': 'c', 'use_case_id': 'sessions', - 'value': 1.0, ? -- + 'value': 1, }, - [ - ( - 'namespace', - b'sessions', - ), - ( - 'mapping_sources', - b'ch', - ), - ( - 'metric_type', - 'c', - ), - ], + [], ? + ), ( { 'mapping_meta': { 'c': { '2': 'd:sessions/duration@second', '3': 'environment', '7': 'production', '9': 'session.status', }, 'h': { '5': 'healthy', }, }, 'metric_id': 2, 'org_id': 1, 'project_id': 3, 'retention_days': 30, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 7, '9': 5, }, 'timestamp': 1711058601, 'type': 'd', 'use_case_id': 'sessions', 'value': [ 4, 5, 6, ], }, - [ - ( - 'namespace', - b'sessions', - ), - ( - 'mapping_sources', - b'ch', - ), - ( - 'metric_type', - 'd', - ), - ], + [], ? + ), ( { 'mapping_meta': { 'c': { '3': 'environment', '7': 'production', '8': 's:sessions/error@none', '9': 'session.status', }, 'd': { '4': 'errored', }, }, 'metric_id': 8, 'org_id': 1, 'project_id': 3,
backend test (6, 14): tests/sentry/sentry_metrics/test_batch.py#L1402
test_batch_resolve_with_values_not_indexed AssertionError: assert [({'mapping_m... 3, ...}, [])] == [({'mapping_m...type', 's')])] At index 0 diff: ({'tags': {'3': 'production', '5': 'init'}, 'version': 2, 'retention_days': 90, 'mapping_meta': {'c': {'1': 'c:sessions/session@none', '5': 'session.status', '3': 'environment'}}, 'use_case_id': 'sessions', 'metric_id': 1, 'org_id': 1, 'timestamp': 1711058601, 'project_id': 3, 'type': 'c', 'value': 1, 'sentry_received_timestamp': 1711058601.082724}, []) != ({'version': 2, 'mapping_meta': {'c': {'1': 'c:sessions/session@none', '3': 'environment', '5': 'session.status'}}, 'metric_id': 1, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'tags': {'3': 'production', '5': 'init'}, 'timestamp': 1711058601, 'type': 'c', 'use_case_id': 'sessions', 'value': 1.0, 'sentry_received_timestamp': 1711058601.082724}, [('namespace', b'sessions'), ('mapping_sources', b'c'), ('metric_type', 'c')]) Full diff: [ ( { 'mapping_meta': { 'c': { '1': 'c:sessions/session@none', '3': 'environment', '5': 'session.status', }, }, 'metric_id': 1, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 'production', '5': 'init', }, 'timestamp': 1711058601, 'type': 'c', 'use_case_id': 'sessions', - 'value': 1.0, ? -- + 'value': 1, 'version': 2, }, - [ - ( - 'namespace', - b'sessions', - ), - ( - 'mapping_sources', - b'c', - ), - ( - 'metric_type', - 'c', - ), - ], + [], ? + ), ( { 'mapping_meta': { 'c': { '2': 'd:sessions/duration@second', '3': 'environment', '5': 'session.status', }, }, 'metric_id': 2, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 'production', '5': 'healthy', }, 'timestamp': 1711058601, 'type': 'd', 'use_case_id': 'sessions', 'value': [ 4, 5, 6, ], 'version': 2, }, - [ - ( - 'namespace', - b'sessions', - ), - ( - 'mapping_sources', - b'c', - ), - ( - 'metric_type', - 'd', - ), - ], + [], ? + ), ( { 'mapping_meta': { 'c': { '3': 'environment', '4': 's:sessions/error@none', '5': 'session.status', }, }, 'metric_id': 4, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 'production', '5': 'errored', }, 'timestamp': 1711058601, 'type': 's', 'use_case_id
backend test (6, 14): tests/sentry/sentry_metrics/test_batch.py#L1562
test_metric_id_rate_limited AssertionError: assert [({'mapping_m... 3, ...}, [])] == [({'mapping_m...type', 's')])] At index 0 diff: ({'tags': {'3': 7, '9': 4}, 'retention_days': 90, 'mapping_meta': {'d': {'None': 's:sessions/error@none', '4': 'errored'}, 'c': {'7': 'production', '9': 'session.status', '3': 'environment'}}, 'use_case_id': 'sessions', 'metric_id': 8, 'org_id': 1, 'timestamp': 1711058601, 'project_id': 3, 'type': 's', 'value': [3], 'sentry_received_timestamp': 1711058601.082724}, []) != ({'mapping_meta': {'c': {'3': 'environment', '7': 'production', '9': 'session.status'}, 'd': {'4': 'errored', 'None': 's:sessions/error@none'}}, 'metric_id': 8, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'tags': {'3': 7, '9': 4}, 'timestamp': 1711058601, 'type': 's', 'use_case_id': 'sessions', 'value': [3], 'sentry_received_timestamp': 1711058601.082724}, [('namespace', b'sessions'), ('mapping_sources', b'cd'), ('metric_type', 's')]) Full diff: [ ( { 'mapping_meta': { 'c': { '3': 'environment', '7': 'production', '9': 'session.status', }, 'd': { '4': 'errored', 'None': 's:sessions/error@none', }, }, 'metric_id': 8, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 7, '9': 4, }, 'timestamp': 1711058601, 'type': 's', 'use_case_id': 'sessions', 'value': [ 3, ], }, - [ - ( - 'namespace', - b'sessions', - ), - ( - 'mapping_sources', - b'cd', - ), - ( - 'metric_type', - 's', - ), - ], + [], ? + ), ]
backend test (6, 14): tests/sentry/sentry_metrics/test_batch.py#L1777
test_tag_value_rate_limited AssertionError: assert [({'mapping_m... 3, ...}, [])] == [({'mapping_m...type', 'd')])] At index 0 diff: ({'tags': {'3': 7, '9': 6}, 'retention_days': 90, 'mapping_meta': {'c': {'1': 'c:sessions/session@none', '7': 'production', '9': 'session.status', '3': 'environment'}, 'h': {'6': 'init'}}, 'use_case_id': 'sessions', 'metric_id': 1, 'org_id': 1, 'timestamp': 1711058601, 'project_id': 3, 'type': 'c', 'value': 1, 'sentry_received_timestamp': 1711058601.082724}, []) != ({'mapping_meta': {'c': {'1': 'c:sessions/session@none', '3': 'environment', '7': 'production', '9': 'session.status'}, 'h': {'6': 'init'}}, 'metric_id': 1, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'tags': {'3': 7, '9': 6}, 'timestamp': 1711058601, 'type': 'c', 'use_case_id': 'sessions', 'value': 1.0, 'sentry_received_timestamp': 1711058601.082724}, [('namespace', b'sessions'), ('mapping_sources', b'ch'), ('metric_type', 'c')]) Full diff: [ ( { 'mapping_meta': { 'c': { '1': 'c:sessions/session@none', '3': 'environment', '7': 'production', '9': 'session.status', }, 'h': { '6': 'init', }, }, 'metric_id': 1, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 7, '9': 6, }, 'timestamp': 1711058601, 'type': 'c', 'use_case_id': 'sessions', - 'value': 1.0, ? -- + 'value': 1, }, - [ - ( - 'namespace', - b'sessions', - ), - ( - 'mapping_sources', - b'ch', - ), - ( - 'metric_type', - 'c', - ), - ], + [], ? + ), ( { 'mapping_meta': { 'c': { '2': 'd:sessions/duration@second', '3': 'environment', '7': 'production', '9': 'session.status', }, 'h': { '5': 'healthy', }, }, 'metric_id': 2, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '3': 7, '9': 5, }, 'timestamp': 1711058601, 'type': 'd', 'use_case_id': 'sessions', 'value': [ 4, 5, 6, ], }, - [ - ( - 'namespace', - b'sessions', - ), - ( - 'mapping_sources', - b'ch', - ), - ( - 'metric_type', - 'd', - ), - ], + [], ? + ), ]
backend test (6, 14): tests/sentry/sentry_metrics/test_batch.py#L1929
test_one_org_limited AssertionError: assert [({'mapping_m... 3, ...}, [])] == [({'mapping_m...type', 'd')])] At index 0 diff: ({'tags': {'2': 4, '5': 3}, 'retention_days': 90, 'mapping_meta': {'c': {'4': 'production', '1': 'd:sessions/duration@second', '5': 'session.status', '2': 'environment'}, 'h': {'3': 'healthy'}}, 'use_case_id': 'sessions', 'metric_id': 1, 'org_id': 2, 'timestamp': 1711058601, 'project_id': 3, 'type': 'd', 'value': [4, 5, 6], 'sentry_received_timestamp': 1711058601.082724}, []) != ({'mapping_meta': {'c': {'1': 'd:sessions/duration@second', '2': 'environment', '4': 'production', '5': 'session.status'}, 'h': {'3': 'healthy'}}, 'metric_id': 1, 'org_id': 2, 'project_id': 3, 'retention_days': 90, 'tags': {'2': 4, '5': 3}, 'timestamp': 1711058601, 'type': 'd', 'use_case_id': 'sessions', 'value': [4, 5, 6], 'sentry_received_timestamp': 1711058601.082724}, [('namespace', b'sessions'), ('mapping_sources', b'ch'), ('metric_type', 'd')]) Full diff: [ ( { 'mapping_meta': { 'c': { '1': 'd:sessions/duration@second', '2': 'environment', '4': 'production', '5': 'session.status', }, 'h': { '3': 'healthy', }, }, 'metric_id': 1, 'org_id': 2, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '2': 4, '5': 3, }, 'timestamp': 1711058601, 'type': 'd', 'use_case_id': 'sessions', 'value': [ 4, 5, 6, ], }, - [ - ( - 'namespace', - b'sessions', - ), - ( - 'mapping_sources', - b'ch', - ), - ( - 'metric_type', - 'd', - ), - ], + [], ? + ), ]
backend test (6, 14): tests/sentry/sentry_metrics/test_batch.py#L2038
test_cardinality_limiter AssertionError: assert [({'mapping_m... 3, ...}, [])] == [({'mapping_m...type', 's')])] At index 0 diff: ({'tags': {'1': 3, '5': 2}, 'retention_days': 90, 'mapping_meta': {'c': {'4': 's:sessions/error@none', '3': 'production', '2': 'errored', '5': 'session.status', '1': 'environment'}}, 'use_case_id': 'sessions', 'metric_id': 4, 'org_id': 1, 'timestamp': 1711058601, 'project_id': 3, 'type': 's', 'value': [3], 'sentry_received_timestamp': 1711058601.082724}, []) != ({'mapping_meta': {'c': {'1': 'environment', '2': 'errored', '3': 'production', '4': 's:sessions/error@none', '5': 'session.status'}}, 'metric_id': 4, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'tags': {'1': 3, '5': 2}, 'timestamp': 1711058601, 'type': 's', 'use_case_id': 'sessions', 'value': [3], 'sentry_received_timestamp': 1711058601.082724}, [('namespace', b'sessions'), ('mapping_sources', b'c'), ('metric_type', 's')]) Full diff: [ ( { 'mapping_meta': { 'c': { '1': 'environment', '2': 'errored', '3': 'production', '4': 's:sessions/error@none', '5': 'session.status', }, }, 'metric_id': 4, 'org_id': 1, 'project_id': 3, 'retention_days': 90, 'sentry_received_timestamp': 1711058601.082724, 'tags': { '1': 3, '5': 2, }, 'timestamp': 1711058601, 'type': 's', 'use_case_id': 'sessions', 'value': [ 3, ], }, - [ - ( - 'namespace', - b'sessions', - ), - ( - 'mapping_sources', - b'c', - ), - ( - 'metric_type', - 's', - ), - ], + [], ? + ), ]
backend test (6, 14)
Process completed with exit code 2.
backend test (4, 14): src/sentry/api/event_search.py#L921
"is:" queries are not supported in this search.
backend test (4, 14): src/sentry/api/event_search.py#L921
"is:" queries are not supported in this search.
backend test (4, 14): src/sentry/api/event_search.py#L921
"is:" queries are not supported in this search.
Backend
Process completed with exit code 1.