fix: Propagate User updates to the active Session #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In case the session was not yet flushed, we can still set the User
flub
reviewed
Nov 19, 2020
| @@ -178,6 +178,9 @@ impl Scope { | |||
|
|
|||
| /// Sets the user for the current scope. | |||
There was a problem hiding this comment.
Can you update this doc comment.
What happens when there is a session? When will the session not see this update?
| @@ -178,6 +178,9 @@ impl Scope { | |||
|
|
|||
| /// Sets the user for the current scope. | |||
| pub fn set_user(&mut self, user: Option<User>) { | |||
| if let Some(session) = self.session.lock().unwrap().as_mut() { | |||
There was a problem hiding this comment.
a method on a scope is supposed to affect the session?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the session was not yet flushed, we can still set the User.
Question is: Should we flush sessions as soon as we capture anything else or not?