Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove legacy rnpm config #3811

Merged
merged 2 commits into from May 13, 2024
Merged

Conversation

szymonrybczak
Copy link
Contributor

馃摙 Type of change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring

馃摐 Description

This Pull Request removes legacy rnpm config. rnpm was depracated ~8 years ago, and currently there's no tool that read this property.

馃挕 Motivation and Context

Make things simpler.

馃挌 How did you test it?

馃摑 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled
  • All tests passing
  • No breaking changes

馃敭 Next steps

@krystofwoldrich
Copy link
Member

Thanks, totally make sense.

For context these are the docs of rnpm deprecation and removal in RN Cli v4. https://github.com/react-native-community/cli/blob/8ba278e2ca4c29ee209493bb85a10df5e36b66bb/docs/configuration.md#migration-guide

This config was replaced by https://github.com/getsentry/sentry-react-native/blob/3e864f9297b0aeb2c939615eb2f96ac4c42f1c35/react-native.config.js

@krystofwoldrich krystofwoldrich merged commit 8e270b4 into getsentry:main May 13, 2024
44 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants