Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): update Cocoa SDK to v8.25.2 #3802

Merged
merged 1 commit into from May 8, 2024
Merged

chore(deps): update Cocoa SDK to v8.25.2 #3802

merged 1 commit into from May 8, 2024

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented May 7, 2024 •
edited

Bumps scripts/update-cocoa.sh from 8.25.0 to 8.25.2.

Auto-generated by a dependency updater.

Changelog

8.25.2

Fixes

  • 'SentryFileManager+Test.h' file not found (#3950)

8.25.1

Features

  • Add option to use own NSURLSession for transport (#3811)
  • Support sending GraphQL operation names in HTTP breadcrumbs (#3931)

Fixes

  • Ignore SentryFramesTracker thread sanitizer data races (#3922)
  • Handle no releaseName in WatchDogTerminationLogic (#3919)
  • Stop SessionReplay when closing SDK (#3941)

Improvements

  • Remove not needed lock for logging (#3934)
  • Session replay Improvements (#3877)
    • Use image average color and text font color to redact session replay
    • Removed iOS 16 restriction from session replay
    • Performance improvement

@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label May 7, 2024
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from 97b6fbe to 823c878 Compare May 7, 2024 16:56
@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented May 7, 2024 •
edited

Android (legacy) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 415.96 ms 448.26 ms 32.30 ms
Size 17.73 MiB 19.94 MiB 2.20 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d197b5c+dirty 338.94 ms 354.87 ms 15.93 ms
6e8584e 447.10 ms 474.71 ms 27.61 ms
dadc233+dirty 333.78 ms 343.94 ms 10.16 ms
2534337 394.15 ms 415.12 ms 20.97 ms
f06c879 408.41 ms 424.54 ms 16.13 ms
15c80ab+dirty 336.27 ms 350.58 ms 14.31 ms
76d1baf+dirty 335.72 ms 355.52 ms 19.80 ms
9c48b2c 349.24 ms 385.96 ms 36.72 ms
0677344 327.74 ms 337.14 ms 9.40 ms
5446992 403.40 ms 426.70 ms 23.30 ms

App size

Revision Plain With Sentry Diff
d197b5c+dirty 17.73 MiB 20.04 MiB 2.31 MiB
6e8584e 17.73 MiB 19.86 MiB 2.12 MiB
dadc233+dirty 17.73 MiB 19.75 MiB 2.02 MiB
2534337 17.73 MiB 19.84 MiB 2.11 MiB
f06c879 17.73 MiB 19.85 MiB 2.12 MiB
15c80ab+dirty 17.73 MiB 20.04 MiB 2.31 MiB
76d1baf+dirty 17.73 MiB 20.04 MiB 2.31 MiB
9c48b2c 17.73 MiB 19.80 MiB 2.07 MiB
0677344 17.73 MiB 19.81 MiB 2.07 MiB
5446992 17.73 MiB 19.85 MiB 2.12 MiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
a4302f1 398.60 ms 428.38 ms 29.78 ms
955f10d 351.88 ms 364.50 ms 12.62 ms
1362675 403.63 ms 420.22 ms 16.60 ms
bcbaefb 386.71 ms 419.33 ms 32.62 ms
1dc092f 420.22 ms 434.90 ms 14.68 ms
c1659ab 333.94 ms 356.55 ms 22.61 ms
adb21f0 395.34 ms 419.46 ms 24.12 ms
19e1ada 407.51 ms 423.04 ms 15.53 ms
357b71f 401.70 ms 415.62 ms 13.92 ms
8ba8074 326.52 ms 339.04 ms 12.52 ms

App size

Revision Plain With Sentry Diff
a4302f1 17.73 MiB 19.85 MiB 2.12 MiB
955f10d 17.73 MiB 19.80 MiB 2.07 MiB
1362675 17.73 MiB 19.84 MiB 2.10 MiB
bcbaefb 17.73 MiB 19.85 MiB 2.11 MiB
1dc092f 17.73 MiB 19.84 MiB 2.10 MiB
c1659ab 17.73 MiB 19.83 MiB 2.09 MiB
adb21f0 17.73 MiB 19.83 MiB 2.10 MiB
19e1ada 17.73 MiB 19.85 MiB 2.12 MiB
357b71f 17.73 MiB 19.86 MiB 2.12 MiB
8ba8074 17.73 MiB 19.81 MiB 2.08 MiB

@github-actions GitHub Actions
Copy link
Contributor Author

github-actions bot commented May 7, 2024 •
edited

Android (new) Performance metrics 🚀

  Plain With Sentry Diff
Startup time 391.22 ms 415.90 ms 24.67 ms
Size 7.15 MiB 8.21 MiB 1.06 MiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
f06c879+dirty 361.27 ms 407.88 ms 46.61 ms
d197b5c+dirty 258.75 ms 313.61 ms 54.86 ms
1d86dd6+dirty 335.76 ms 371.22 ms 35.46 ms
dadc233+dirty 363.19 ms 370.37 ms 7.18 ms
728164b+dirty 335.93 ms 342.94 ms 7.01 ms
e2b64fe+dirty 258.82 ms 304.26 ms 45.44 ms
0db0c72+dirty 335.20 ms 351.06 ms 15.86 ms
d361d38+dirty 257.72 ms 318.76 ms 61.04 ms
ad6c299+dirty 336.47 ms 362.89 ms 26.42 ms
27ef4ee+dirty 296.71 ms 351.00 ms 54.29 ms

App size

Revision Plain With Sentry Diff
f06c879+dirty 7.15 MiB 8.12 MiB 997.78 KiB
d197b5c+dirty 7.15 MiB 8.09 MiB 962.72 KiB
1d86dd6+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
dadc233+dirty 7.15 MiB 8.04 MiB 910.84 KiB
728164b+dirty 7.15 MiB 8.12 MiB 997.71 KiB
e2b64fe+dirty 7.15 MiB 8.07 MiB 947.16 KiB
0db0c72+dirty 7.15 MiB 8.04 MiB 911.02 KiB
d361d38+dirty 7.15 MiB 8.08 MiB 959.34 KiB
ad6c299+dirty 7.15 MiB 8.04 MiB 912.17 KiB
27ef4ee+dirty 7.15 MiB 8.08 MiB 959.49 KiB

Previous results on branch: deps/scripts/update-cocoa.sh

Startup times

Revision Plain With Sentry Diff
a4302f1+dirty 383.10 ms 405.33 ms 22.23 ms
19e1ada+dirty 366.56 ms 393.32 ms 26.76 ms
5cca71b+dirty 288.29 ms 341.60 ms 53.31 ms
69568a5+dirty 371.27 ms 409.40 ms 38.13 ms
357b71f+dirty 318.48 ms 354.55 ms 36.07 ms
955f10d+dirty 306.27 ms 385.83 ms 79.57 ms
7787a29+dirty 340.33 ms 368.82 ms 28.48 ms
c1659ab+dirty 267.34 ms 337.14 ms 69.80 ms
1573004+dirty 343.73 ms 369.70 ms 25.97 ms
8da52c9+dirty 269.29 ms 290.76 ms 21.47 ms

App size

Revision Plain With Sentry Diff
a4302f1+dirty 7.15 MiB 8.12 MiB 999.45 KiB
19e1ada+dirty 7.15 MiB 8.12 MiB 999.34 KiB
5cca71b+dirty 7.15 MiB 8.10 MiB 972.55 KiB
69568a5+dirty 7.15 MiB 8.18 MiB 1.03 MiB
357b71f+dirty 7.15 MiB 8.13 MiB 1002.12 KiB
955f10d+dirty 7.15 MiB 8.07 MiB 946.13 KiB
7787a29+dirty 7.15 MiB 8.13 MiB 1002.18 KiB
c1659ab+dirty 7.15 MiB 8.10 MiB 972.53 KiB
1573004+dirty 7.15 MiB 8.10 MiB 980.89 KiB
8da52c9+dirty 7.15 MiB 8.09 MiB 962.83 KiB

krystofwoldrich
krystofwoldrich requested changes May 7, 2024
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO NOT MERGE

RN DEV builds break on:

Error: 'SentryFileManager+Test.h' file not found
#    import "SentryFileManager+Test.h"

Waiting for cocoa 8.25.2

@krystofwoldrich krystofwoldrich mentioned this pull request May 7, 2024
Merged
7 tasks
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from 823c878 to 63ce8d7 Compare May 7, 2024 18:05
@github-actions github-actions bot changed the title chore(deps): update Cocoa SDK to v8.25.1 chore(deps): update Cocoa SDK to v8.25.2 May 8, 2024
@bruno-garcia bruno-garcia force-pushed the deps/scripts/update-cocoa.sh branch from 63ce8d7 to b564ff7 Compare May 8, 2024 03:03
krystofwoldrich
krystofwoldrich approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@krystofwoldrich krystofwoldrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@krystofwoldrich krystofwoldrich merged commit d6eb796 into main May 8, 2024
58 of 60 checks passed
@krystofwoldrich krystofwoldrich deleted the deps/scripts/update-cocoa.sh branch May 8, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krystofwoldrich krystofwoldrich krystofwoldrich approved these changes

@lucas-zimerman lucas-zimerman Awaiting requested review from lucas-zimerman lucas-zimerman is a code owner

Assignees
No one assigned
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@krystofwoldrich @web-flow