feat(integrations): Update integration to new JS interface #3721
+1,312
−1,785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Update integration to new JS interface ([#3721](https://github.com/getsentry/sentry-react-native/pull/3721))If none of the above apply, you can opt out of this check by adding |
Android (legacy) Performance metrics 🚀
|
Android (new) Performance metrics 🚀
|
iOS (legacy) Performance metrics 🚀
|
AbhiPrasad
requested changes
Apr 2, 2024
| hint.syntheticException.stack, | ||
| getFramesToPop(hint.syntheticException), | ||
| ); | ||
| export const debugSymbolicatorIntegration: IntegrationFn = () => { |
There was a problem hiding this comment.
we should backport the integrations to a v5 release so that users can migrate to the functional integrations more incrementally.
You can look at https://github.com/getsentry/sentry-javascript/blob/fdcd1adfe65becd9c605412cdd474eb676714bc4/packages/integrations/src/dedupe.ts#L9-L45 as an example of this in v7.
There was a problem hiding this comment.
Yes, I agree, I'll prepare it.
This was referenced Apr 3, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the React Native integration to use the new factory functions returning plain JS object style.