fix(sample): Fix bare sample Pods to work with dynamic frameworks (#3767

)
getsentry · Apr 22, 2024 · 91c93bd · 91c93bd
1 parent d20a569
commit 91c93bd
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/.github/workflows/sample-application.yml b/.github/workflows/sample-application.yml
@@ -28,7 +28,7 @@ jobs:
           access_token: ${{ github.token }}
 
   build:
-    name: Build ${{ matrix.rn-architecture }} ${{ matrix.platform }} ${{ matrix.build-type }}
+    name: Build ${{ matrix.rn-architecture }} ${{ matrix.platform }} ${{ matrix.build-type }} ${{ matrix.ios-use-frameworks}}
     runs-on: ${{ matrix.runs-on }}
     needs: [diff_check]
     if: ${{ needs.diff_check.outputs.skip_ci != 'true' }}
@@ -39,6 +39,7 @@ jobs:
       fail-fast: false
       matrix:
         rn-architecture: ['legacy', 'new']
+        ios-use-frameworks: ['no-frameworks', 'dynamic-frameworks']
         platform: ['android', 'ios']
         build-type: ['dev', 'production']
         include:
@@ -48,6 +49,11 @@ jobs:
             device: 'iPhone 14'
           - platform: android
             runs-on: ubuntu-latest
+        exclude:
+          - platform: 'android'
+            ios-use-frameworks: 'dynamic-frameworks'
+          - rn-architecture: 'new'
+            ios-use-frameworks: 'dynamic-frameworks'
     steps:
       - uses: actions/checkout@v4
 
@@ -95,6 +101,7 @@ jobs:
         run: |
           [[ "${{ matrix.build-type }}" == "production" ]] && ENABLE_PROD=1 || ENABLE_PROD=0
           [[ "${{ matrix.rn-architecture }}" == "new" ]] && ENABLE_NEW_ARCH=1 || ENABLE_NEW_ARCH=0
+          [[ "${{ matrix.ios-use-frameworks }}" == "dynamic-frameworks" ]] && export USE_FRAMEWORKS=dynamic && export NO_FLIPPER=1
           echo "ENABLE_PROD=$ENABLE_PROD"
           echo "ENABLE_NEW_ARCH=$ENABLE_NEW_ARCH"
           PRODUCTION=$ENABLE_PROD RCT_NEW_ARCH_ENABLED=$ENABLE_NEW_ARCH bundle exec pod install
@@ -135,5 +142,5 @@ jobs:
         if: ${{ always() }}
         uses: actions/upload-artifact@v4
         with:
-          name: build-sample-${{ matrix.rn-architecture }}-${{ matrix.platform }}-${{ matrix.build-type }}-logs
+          name: build-sample-${{ matrix.rn-architecture }}-${{ matrix.platform }}-${{ matrix.build-type }}-${{ matrix.ios-use-frameworks}}-logs
           path: samples/react-native/ios/*.log
diff --git a/samples/react-native/ios/Podfile b/samples/react-native/ios/Podfile
@@ -21,6 +21,17 @@ linkage = ENV['USE_FRAMEWORKS']
 if linkage != nil
   Pod::UI.puts "Configuring Pod with #{linkage}ally linked Frameworks".green
   use_frameworks! :linkage => linkage.to_sym
+  pre_install do |installer|
+    installer.pod_targets.each do |pod|
+      # RNScreens and RNReanimated don't work when dynamically linked
+      # Fix from https://github.com/software-mansion/react-native-screens/issues/1963#issuecomment-1848246731
+      if pod.name.eql?('RNReanimated') || pod.name.eql?('RNScreens')
+        def pod.build_type;
+          Pod::BuildType.static_library
+        end
+      end
+    end
+  end
 end
 
 target 'sentryreactnativesample' do