Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(celery): Send Celery retry count #2971

Merged
merged 3 commits into from May 15, 2024

Conversation

szokeasaurusrex
Copy link
Member

@szokeasaurusrex szokeasaurusrex commented Apr 11, 2024

Depends on #2984

ref #2959

@szokeasaurusrex szokeasaurusrex self-assigned this Apr 12, 2024
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-retry-count branch from 4162d95 to bbf6bd3 Compare April 12, 2024 11:15
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-retry-count branch from bbf6bd3 to 57f1d44 Compare April 24, 2024 09:58
@szokeasaurusrex szokeasaurusrex changed the base branch from sentry-sdk-2.0 to szokeasaurusrex/celery-queue-consumer-default-exchange April 24, 2024 09:58
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-retry-count branch 3 times, most recently from 8a657d8 to ef03803 Compare April 24, 2024 11:39
@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review April 24, 2024 13:09
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-queue-consumer-default-exchange branch from 8028917 to 5a99aad Compare April 24, 2024 13:55
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-retry-count branch from 79d584d to 57bd97e Compare April 24, 2024 13:56
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-queue-consumer-default-exchange branch from 2fea931 to 3bf4c12 Compare April 26, 2024 10:18
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-retry-count branch from edf4c0a to 5baf5dd Compare April 26, 2024 10:21
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-queue-consumer-default-exchange branch from f1671f5 to 67e2531 Compare April 30, 2024 15:16
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-retry-count branch from 5baf5dd to 73c11e8 Compare April 30, 2024 15:18
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-queue-consumer-default-exchange branch from 67e2531 to e8ae74e Compare May 10, 2024 12:29
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-retry-count branch from 42f3b19 to 6ed9bf7 Compare May 10, 2024 12:29
szokeasaurusrex and others added 3 commits May 15, 2024 14:18
Send the retry count of a Celery task as a span data attribute on the "queue.process" span. Also, add tests for this feature.

Ref #2961
Set Celery task ID on the "queue.process" span, and add tests for this new behavior.

Closes #2974
Set the "messaging.system" data on the "queue.process" span in the Celery integration. The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. Also, add tests for this feature.

ref #2951
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-retry-count branch from 6ed9bf7 to ff10b77 Compare May 15, 2024 12:22
@szokeasaurusrex szokeasaurusrex force-pushed the szokeasaurusrex/celery-queue-consumer-default-exchange branch from e8ae74e to 72ac630 Compare May 15, 2024 12:22
Base automatically changed from szokeasaurusrex/celery-queue-consumer-default-exchange to master May 15, 2024 12:33
@szokeasaurusrex szokeasaurusrex merged commit a02eb9c into master May 15, 2024
229 of 272 checks passed
@szokeasaurusrex szokeasaurusrex deleted the szokeasaurusrex/celery-retry-count branch May 15, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants