New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(spans): Add topic definition for buffered-segment topic #237
feat(spans): Add topic definition for buffered-segment topic #237
Conversation
versions in use: The following repositories use one of the schemas you are editing. It is recommended to roll out schema changes in small PRs, meaning that if those used versions lag behind the latest, it is probably best to update those services before rolling out your change.
latest version: 0.1.61 benign changesschemas/snuba-spans.v1.schema.json
✅ This PR should be safe to roll out to consumers first. Make sure to bump
...then in the other repos:
Take a look at the README for how to release a new version of sentry-kafka-schemas. |
We're building a new pipeline to support performance issues with span streaming,
at a high level, it looks like this
the
buffered-segments
topic will expect to receive a list of spans. As of thismoment, these spans will have the exact same schema as ones we consume
from the
snuba-spans
kafka topic, the SpanEvent definition is just copied fromthe snuba-span schema. we might deserialize the spans to drop fields before pushing to redis
as a memory optimization at which point the span schemas will diverge.