Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add retention values to DLQ #228

Merged
merged 2 commits into from Mar 6, 2024
Merged

feat: Add retention values to DLQ #228

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12934f7
feat: Add retention values to DLQ
lynnagara Mar 1, 2024
cc6ae21
lol
lynnagara Mar 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/tests/test_sentry_kafka_schemas.py
View file
Open in desktop
Expand Up @@ -9,7 +9,7 @@ def test_get_topic() -> None:
assert topic_data["topic_creation_config"] == {"max.message.bytes": "2000000"}

# Topic without creation config
topic_name_no_config = "snuba-dead-letter-replays"
topic_name_no_config = "outcomes"
topic_data = get_topic(topic_name_no_config)
assert topic_data["topic_creation_config"] == {}

Expand Down
2 changes: 2 additions & 0 deletions topics/ingest-events-dlq.yaml
View file
Open in desktop
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/ingest-generic-metrics-dlq.yaml
View file
Open in desktop
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/ingest-metrics-dlq.yaml
View file
Open in desktop
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/snuba-dead-letter-generic-metrics.yaml
View file
Open in desktop
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/snuba-dead-letter-group-attributes.yaml
View file
Open in desktop
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/snuba-dead-letter-metrics.yaml
View file
Open in desktop
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/snuba-dead-letter-querylog.yaml
View file
Open in desktop
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"
2 changes: 2 additions & 0 deletions topics/snuba-dead-letter-replays.yaml
View file
Open in desktop
Expand Up @@ -12,3 +12,5 @@ schemas:
resource: any.json
examples:
- any/
topic_creation_config:
log.retention.minutes: "10080"