feat: Add retention values to DLQ (#228)

DLQ retention is one week. This matches what we do across all DLQ topics in Sentry prod.
getsentry · Mar 6, 2024 · 266f25e · 266f25e
1 parent 5d7ff5d
commit 266f25e
Show file tree

Hide file tree

Showing 9 changed files with 17 additions and 1 deletion.
diff --git a/python/tests/test_sentry_kafka_schemas.py b/python/tests/test_sentry_kafka_schemas.py
@@ -9,7 +9,7 @@ def test_get_topic() -> None:
     assert topic_data["topic_creation_config"] == {"max.message.bytes": "2000000"}
 
     # Topic without creation config
-    topic_name_no_config = "snuba-dead-letter-replays"
+    topic_name_no_config = "outcomes"
     topic_data = get_topic(topic_name_no_config)
     assert topic_data["topic_creation_config"] == {}
 

diff --git a/topics/ingest-events-dlq.yaml b/topics/ingest-events-dlq.yaml
@@ -12,3 +12,5 @@ schemas:
     resource: any.json
     examples:
       - any/
+topic_creation_config:
+  log.retention.minutes: "10080"
diff --git a/topics/ingest-generic-metrics-dlq.yaml b/topics/ingest-generic-metrics-dlq.yaml
@@ -12,3 +12,5 @@ schemas:
     resource: any.json
     examples:
       - any/
+topic_creation_config:
+  log.retention.minutes: "10080"
diff --git a/topics/ingest-metrics-dlq.yaml b/topics/ingest-metrics-dlq.yaml
@@ -12,3 +12,5 @@ schemas:
     resource: any.json
     examples:
       - any/
+topic_creation_config:
+  log.retention.minutes: "10080"
diff --git a/topics/snuba-dead-letter-generic-metrics.yaml b/topics/snuba-dead-letter-generic-metrics.yaml
@@ -12,3 +12,5 @@ schemas:
     resource: any.json
     examples:
       - any/
+topic_creation_config:
+  log.retention.minutes: "10080"
diff --git a/topics/snuba-dead-letter-group-attributes.yaml b/topics/snuba-dead-letter-group-attributes.yaml
@@ -12,3 +12,5 @@ schemas:
     resource: any.json
     examples:
       - any/
+topic_creation_config:
+  log.retention.minutes: "10080"
diff --git a/topics/snuba-dead-letter-metrics.yaml b/topics/snuba-dead-letter-metrics.yaml
@@ -12,3 +12,5 @@ schemas:
     resource: any.json
     examples:
       - any/
+topic_creation_config:
+  log.retention.minutes: "10080"
diff --git a/topics/snuba-dead-letter-querylog.yaml b/topics/snuba-dead-letter-querylog.yaml
@@ -12,3 +12,5 @@ schemas:
     resource: any.json
     examples:
       - any/
+topic_creation_config:
+  log.retention.minutes: "10080"
diff --git a/topics/snuba-dead-letter-replays.yaml b/topics/snuba-dead-letter-replays.yaml
@@ -12,3 +12,5 @@ schemas:
     resource: any.json
     examples:
       - any/
+topic_creation_config:
+  log.retention.minutes: "10080"