Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make internal Sentry flags non-enumerable in fill util #1850

Merged
merged 2 commits into from
Jan 31, 2019

Conversation

kamilogorek
Copy link
Contributor

Fixes #1849

@getsentry-bot
Copy link
Contributor

getsentry-bot commented Jan 23, 2019

Fails
🚫

TSLint failed: @sentry/browser

  • ERROR: /home/travis/build/getsentry/sentry-javascript/packages/browser/src/integrations/helpers.ts[121, 5]: The key 'enumerable' is not sorted alphabetically
  • ERROR: /home/travis/build/getsentry/sentry-javascript/packages/browser/src/integrations/helpers.ts[129, 7]: The key 'enumerable' is not sorted alphabetically
  • ERROR: /home/travis/build/getsentry/sentry-javascript/packages/browser/src/integrations/helpers.ts[133, 7]: The key 'enumerable' is not sorted alphabetically
Warnings
⚠️ Please add a changelog entry for your changes.
Messages
📖 @sentry/browser gzip'ed minified size: 21.916 kB

Generated by 🚫 dangerJS

@atk
Copy link

atk commented Jan 23, 2019

You have 2 more places in which you should probably change that.

@kamilogorek
Copy link
Contributor Author

@atk can you point them out?

@atk
Copy link

atk commented Jan 23, 2019

https://github.com/getsentry/sentry-javascript/blob/master/packages/browser/src/integrations/helpers.ts#L117

The other one seems to be taken over by fill in your current code base, because I didn't find it anymore (Ionly had your transpiled code to work with).

Sorry it took a bit longer, had to get my kids to sleep.

@kamilogorek
Copy link
Contributor Author

My ack match pattern failed me again :< Thanks @atk! Updated remaining flags.

@atk
Copy link

atk commented Jan 29, 2019

The failure in your build job is the tslint part:

@sentry/browser: $ tslint --format json -p . | tee lint-results.json
@sentry/browser: [{"endPosition":{"character":14,"line":120,"position":3494},"failure":"The key 'enumerable' is not sorted alphabetically","name":"/home/travis/build/getsentry/sentry-javascript/packages/browser/src/integrations/helpers.ts","ruleName":"object-literal-sort-keys","ruleSeverity":"ERROR","startPosition":{"character":4,"line":120,"position":3484}},{"endPosition":{"character":16,"line":128,"position":3740},"failure":"The key 'enumerable' is not sorted alphabetically","name":"/home/travis/build/getsentry/sentry-javascript/packages/browser/src/integrations/helpers.ts","ruleName":"object-literal-sort-keys","ruleSeverity":"ERROR","startPosition":{"character":6,"line":128,"position":3730}},{"endPosition":{"character":16,"line":132,"position":3815},"failure":"The key 'enumerable' is not sorted alphabetically","name":"/home/travis/build/getsentry/sentry-javascript/packages/browser/src/integrations/helpers.ts","ruleName":"object-literal-sort-keys","ruleSeverity":"ERROR","startPosition":{"character":6,"line":132,"position":3805}}]

@kamilogorek kamilogorek changed the base branch from master to major/5 January 31, 2019 11:25
@kamilogorek kamilogorek merged commit acd1b0e into major/5 Jan 31, 2019
@kamilogorek kamilogorek deleted the internal-nonenumerable branch January 31, 2019 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants