feat(node): Ensure fastify spans have better data #12106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This ensures we have correct op, name & origin for all fastify middleware spans.
mydea
force-pushed
the
fn/fastify-middleware-spans
branch
from
3487263
to
bbaf2e3
Compare
Lms24
approved these changes
May 17, 2024
size-limit report 馃摝
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures we have correct op, name & origin for all fastify middleware spans.
Sadly, we have no good hook in fastify to handle all spans it emits - only
request_handlerspans are passed torequestHook馃槵 so I opted to add aspanStarthook to handle this. Since it would suck to always register this, even without fastify being used, I put this into the fastify error handler - kind of mixing concerns there but I'd say it's fine for this case (as it just enhances the data).I had some issues running this locally, so I changed the playwright config to not be TS which is IMHO ok and simplifies the setup a bit...