Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

experimental wpf integration #1036

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

experimental wpf integration #1036

wants to merge 7 commits into from

Conversation

bruno-garcia
Copy link
Member

@bruno-garcia bruno-garcia commented Jun 2, 2021

Starting from a sample to see what hooks we need.
The goal is to create a new package Sentry.Wpf that already hooks to DispatcherUnhandledException. Additionally it would set up offline caching by default, and create some transactions out of the box.

Once #1013 is done it can also emit release health stats out of the box.

Blocked by #1095

@codecov-commenter
Copy link

codecov-commenter commented Jan 5, 2022

Codecov Report

Merging #1036 (b93554f) into main (7604242) will decrease coverage by 0.20%.
The diff coverage is n/a.

❗ Current head b93554f differs from pull request most recent head a6f3725. Consider uploading reports for the commit a6f3725 to get more accurate results

@@            Coverage Diff             @@
##             main    #1036      +/-   ##
==========================================
- Coverage   84.34%   84.13%   -0.21%     
==========================================
  Files         219      219              
  Lines        7423     7350      -73     
  Branches     1417     1409       -8     
==========================================
- Hits         6261     6184      -77     
+ Misses        735      730       -5     
- Partials      427      436       +9     
Impacted Files Coverage Δ
...als/DiagnosticSource/SentryDiagnosticSubscriber.cs 60.00% <0.00%> (-35.46%) ⬇️
src/Sentry/Infrastructure/TraceDiagnosticLogger.cs 72.72% <0.00%> (-27.28%) ⬇️
src/Sentry/Internal/Extensions/StreamExtensions.cs 89.47% <0.00%> (-10.53%) ⬇️
src/Sentry/Reflection/AssemblyExtensions.cs 66.66% <0.00%> (-10.26%) ⬇️
....EntityFramework/SentryQueryPerformanceListener.cs 76.19% <0.00%> (-10.18%) ⬇️
src/Sentry/Internal/SdkComposer.cs 70.21% <0.00%> (-4.26%) ⬇️
src/Sentry/Internal/Http/RetryAfterHandler.cs 95.83% <0.00%> (-4.17%) ⬇️
...Internals/DiagnosticSource/SentryEFCoreListener.cs 89.28% <0.00%> (-3.74%) ⬇️
src/Sentry/Internal/MonoSentryStackTraceFactory.cs 92.59% <0.00%> (-3.71%) ⬇️
...rc/Sentry/Extensibility/SentryStackTraceFactory.cs 89.24% <0.00%> (-2.89%) ⬇️
... and 31 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 5, 2022

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

- experimental wpf integration ([#1036](https://github.com/getsentry/sentry-dotnet/pull/1036))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against a6f3725

@jamescrosswell
Copy link
Collaborator

@SimonCropp just going through the old pull requests, looking to close any that are no longer active. Is this one still being worked on or should we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants