feat(v8): Update node docs for v8

[mydea]

This is a draft until v8 is released!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
sentry-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	May 13, 2024 3:43pm

[codecov]

Bundle Report

Changes will decrease total bundle size by 1.24kB ⬇️

Bundle name	Size	Change
sentry-docs-server	7.43MB	1.23kB ⬇️
sentry-docs-edge-server	458.51kB	3 bytes ⬇️
sentry-docs-client	6.16MB	6 bytes ⬇️

[s1gr1d]

Thanks for updating 🙌🏻

[timfish]

I think the Configure metrics section can now be removed from all SDKs since it's automatically configured when you first call the functions.

For example, there's no need for this section anymore:
https://sentry-docs-git-v8-docs.sentry.dev/platforms/javascript/guides/node/metrics/#configure-metrics

I can submit a separate PR for this?

[vivianyentran]

Added some copyedits to the content changes

[s1gr1d]

The docs for serverless are in those commits:

• d353e5d
• 16769da
  @mydea

[mydea]

I think the Configure metrics section can now be removed from all SDKs since it's automatically configured when you first call the functions.

For example, there's no need for this section anymore: https://sentry-docs-git-v8-docs.sentry.dev/platforms/javascript/guides/node/metrics/#configure-metrics

I can submit a separate PR for this?

Yes please, that makes sense!

[HazAT]

https://github.com/getsentry/sentry-docs/pull/9906/files#diff-b7e7956822e5458c8c74398728fc9e7fdbd160778dc5860580534facf60db755R18-R20
Isn't this wrong?

The error handler always needs to be last, doing a quick local repro confirms this, you need to have all your routes BEFORE you add the error handler

stale

[timfish]

If node is running ESM source, ie. you're not transpiling the above to CJS, the import ordering makes zero difference. import http from "http" is evaluated and loaded before any code in instrument.js is even executed and libraries will not be instrumented without using the loader detailed later.

When you are using the loader, import-in-the-middle wraps everything in proxies to work around the whole "imports evaluated first" problem.

import-in-the-middle is an module loading interceptor inspired by require-in-the-middle, but specifically for ESM modules. In fact, it can even modify modules after loading time.

Of course, users might be transpiling to CJS, even without their knowledge so maybe it's still important to keep the ordering, but then the loader below will not be required anyway!

[lforst]

Good point. I would err on keeping it as-is for the reason you outlined with transpilation to CJS. Maybe this "accidentally" makes it work for people, but I will let the team decide on monday.

[mydea]

Updated the PR to show require on top as default installation method, plus added the "Installation Methods" section to node guides showing ESM docs, including when to use which. cc @smeubank

[andreiborza]

LGTM