Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flutter replay for Android [waiting for upstream SDK release] #2032

Open
wants to merge 84 commits into
base: main
Choose a base branch
from

Conversation

vaind
Copy link
Collaborator

@vaind vaind commented May 6, 2024

📜 Description

Adds session replay support for Flutter (Android)

  • automatic session replay
  • native errors replay
  • dart errors replay
  • unit test coverage
  • changelog entry (#skip-changelog until then)
  • wait for sentry-java release [SR] Session Replay sentry-java#3339

💡 Motivation and Context

💚 How did you test it?

Unit tests and manually

📝 Checklist

  • I reviewed submitted code
  • I added tests to verify changes
  • No new PII added or SDK only sends newly added PII if sendDefaultPii is enabled
  • I updated the docs if needed
  • All tests passing
  • No breaking changes

🔮 Next steps

Copy link

codecov bot commented May 12, 2024

Codecov Report

Attention: Patch coverage is 71.29187% with 60 lines in your changes are missing coverage. Please review.

Project coverage is 92.69%. Comparing base (31e875c) to head (a93da0b).

Files Patch % Lines
...lutter/lib/src/native/java/sentry_native_java.dart 7.69% 36 Missing ⚠️
flutter/lib/src/replay/widget_filter.dart 83.63% 9 Missing ⚠️
...ib/src/event_processor/replay_event_processor.dart 0.00% 7 Missing ⚠️
flutter/lib/src/native/sentry_native_channel.dart 83.33% 4 Missing ⚠️
flutter/lib/src/replay/recorder.dart 92.30% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2032      +/-   ##
==========================================
- Coverage   95.30%   92.69%   -2.62%     
==========================================
  Files          54       60       +6     
  Lines        1789     1970     +181     
==========================================
+ Hits         1705     1826     +121     
- Misses         84      144      +60     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vaind vaind force-pushed the feat/android-replay branch 2 times, most recently from c6eb9f1 to 5876a6b Compare May 13, 2024 19:29
Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some comments, will do another round of review - cool stuff!

flutter/lib/src/sentry_replay_options.dart Outdated Show resolved Hide resolved
flutter/lib/src/native/java/sentry_native_java.dart Outdated Show resolved Hide resolved
flutter/lib/src/replay/recorder.dart Outdated Show resolved Hide resolved
vaind and others added 4 commits May 14, 2024 14:36
Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
Co-authored-by: Giancarlo Buenaflor <giancarlo_buenaflor@yahoo.com>
@buenaflor
Copy link
Contributor

Sorry for the delay, will look over it once more tomorrow

Copy link
Contributor

@buenaflor buenaflor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good 🚀

@vaind vaind changed the title Flutter replay for Android Flutter replay for Android [blocked by upstream] May 26, 2024
@vaind vaind changed the title Flutter replay for Android [blocked by upstream] Flutter replay for Android [blocked by upstream SDK] May 26, 2024
@vaind vaind changed the title Flutter replay for Android [blocked by upstream SDK] Flutter replay for Android [waiting for upstream SDK release] May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants